Skip to content

gce: Disallow role=apiserver with dns=none#18214

Merged
k8s-ci-robot merged 1 commit into
kubernetes:masterfrom
rifelpet:disallow-gce-apiserver-none
Apr 18, 2026
Merged

gce: Disallow role=apiserver with dns=none#18214
k8s-ci-robot merged 1 commit into
kubernetes:masterfrom
rifelpet:disallow-gce-apiserver-none

Conversation

@rifelpet
Copy link
Copy Markdown
Member

@rifelpet rifelpet commented Apr 18, 2026

We tried allowing this in #18162 but it will require too many changes to be viable for the moment.

@rifelpet
Disallow role=apiserver with dns=none on GCE
9b37c31 
We tried allowing this but it will require too many changes to be viable for the moment.
@k8s-ci-robot k8s-ci-robot added area/api size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 18, 2026
@hakman hakman changed the title Disallow role=apiserver with dns=none on GCE gce: Disallow role=apiserver with dns=none Apr 18, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Apr 18, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 18, 2026
@k8s-triage-robot
Copy link
Copy Markdown

k8s-triage-robot commented Apr 18, 2026

Unknown CLA label state. Rechecking for CLA labels.

Send feedback to sig-contributor-experience at kubernetes/community.

/check-cla
/easycla

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 18, 2026
@hakman
Copy link
Copy Markdown
Member

hakman commented Apr 18, 2026

/override pull-kops-e2e-k8s-aws-calico

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Apr 18, 2026

@hakman: Overrode contexts on behalf of hakman: pull-kops-e2e-k8s-aws-calico

Details

In response to this:

/override pull-kops-e2e-k8s-aws-calico

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot merged commit 8ced3d1 into kubernetes:master Apr 18, 2026
31 of 32 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.36 milestone Apr 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hakman hakman hakman approved these changes

@olemarkus olemarkus Awaiting requested review from olemarkus

Assignees

@hakman hakman

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/api cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

v1.36

Development

Successfully merging this pull request may close these issues.

4 participants

@rifelpet @k8s-ci-robot @k8s-triage-robot @hakman