Skip to content

WIP etcd-manager: scope AWS volume discovery to the owning instance group#18294

Open
hakman wants to merge 2 commits into
kubernetes:masterfrom
hakman:aws-etcd-volumes-ig-tag
Open

WIP etcd-manager: scope AWS volume discovery to the owning instance group#18294
hakman wants to merge 2 commits into
kubernetes:masterfrom
hakman:aws-etcd-volumes-ig-tag

Conversation

@hakman
Copy link
Copy Markdown
Member

@hakman hakman commented May 9, 2026

Tag etcd EBS volumes with kops.k8s.io/instancegroup and add a matching --volume-tag filter to the per-IG manifest, so control-plane nodes sharing an AZ can no longer claim other IG's volume.

/cc @rifelpet

Fixes #14560

hakman added 2 commits May 9, 2026 17:32
Tag etcd EBS volumes with kops.k8s.io/instancegroup and add a matching
--volume-tag filter to the per-IG manifest, so control-plane nodes
sharing an AZ can no longer claim other IG's volume.
@k8s-ci-robot k8s-ci-robot requested a review from rifelpet May 9, 2026 14:35
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels May 9, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign justinsb for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the area/provider/aws Issues or PRs related to aws provider label May 9, 2026
@hakman
Copy link
Copy Markdown
Member Author

hakman commented May 9, 2026

/test pull-kops-aws-upgrade-k135-ko135-to-k136-kolatest-many-addons
/test pull-kops-aws-upgrade-k134-ko134-to-k136-kolatest-many-addons

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

@hakman: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kops-aws-upgrade-k135-ko135-to-k136-kolatest-many-addons 7d2ad3f link false /test pull-kops-aws-upgrade-k135-ko135-to-k136-kolatest-many-addons
pull-kops-aws-upgrade-k134-ko134-to-k136-kolatest-many-addons 7d2ad3f link false /test pull-kops-aws-upgrade-k134-ko134-to-k136-kolatest-many-addons

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@hakman hakman changed the title etcd-manager: scope AWS volume discovery to the owning instance group WIP etcd-manager: scope AWS volume discovery to the owning instance group May 9, 2026
@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels May 9, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/provider/aws Issues or PRs related to aws provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Multiple etcd-managers in the same AWS AZ can claim each other's volumes

2 participants