Skip to content

Adding branch for kube-burner execution#18371

Open
vishnuchalla wants to merge 1 commit into
kubernetes:masterfrom
vishnuchalla:kube-burner
Open

Adding branch for kube-burner execution#18371
vishnuchalla wants to merge 1 commit into
kubernetes:masterfrom
vishnuchalla:kube-burner

Conversation

@vishnuchalla
Copy link
Copy Markdown

Description

Added branching logic for kube-burner execution.

Testing

Will be helpful to test out this pre-submit: kubernetes/test-infra#37069

@k8s-ci-robot k8s-ci-robot requested a review from dims May 19, 2026 22:02
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign dims for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested a review from hakman May 19, 2026 22:02
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

Welcome @vishnuchalla!

It looks like this is your first PR to kubernetes/kops 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kops has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 19, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

Hi @vishnuchalla. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@hakman
Copy link
Copy Markdown
Member

hakman commented May 20, 2026

/cc @serathius @Jefftree

@serathius
Copy link
Copy Markdown
Contributor

What is kube-burner?

CL2_ENABLE_PVS: false
ENABLE_RESTART_COUNT_CHECK: false

if [[ "${SCALE_TEST_TOOL}" == "clusterloader2" ]]; then
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would should have a separate script.

Signed-off-by: Vishnu Challa <vchalla@redhat.com>
@serathius
Copy link
Copy Markdown
Contributor

Was the plan presented to SIG-scalability and approved? I don't see any reviewers or comments.

@hakman
Copy link
Copy Markdown
Member

hakman commented May 20, 2026

@vishnuchalla I think there are some questions here, especially the one regarding SIG-scalability. Please follow up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants