Skip to content

Replace fi.PtrTo with new() builtin#18549

Merged
kubernetes-prow[bot] merged 1 commit into
kubernetes:masterfrom
hakman:modernize-ptrto-new
Jul 10, 2026
Merged

Replace fi.PtrTo with new() builtin#18549
kubernetes-prow[bot] merged 1 commit into
kubernetes:masterfrom
hakman:modernize-ptrto-new

Conversation

@hakman

@hakman hakman commented Jul 8, 2026

Copy link
Copy Markdown
Member

@kubernetes-prow kubernetes-prow Bot requested review from ameukam and rifelpet July 8, 2026 04:35
@kubernetes-prow kubernetes-prow Bot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. area/api area/channels area/kops-controller area/nodeup area/provider/aws Issues or PRs related to aws provider area/provider/azure Issues or PRs related to azure provider area/provider/digitalocean Issues or PRs related to digitalocean provider area/provider/gcp Issues or PRs related to gcp provider area/provider/hetzner Issues or PRs related to Hetzner provider area/provider/openstack Issues or PRs related to openstack provider area/provider/scaleway Issues or PRs related to Scaleway provider area/provider/spotinst Issues or PRs related to spotinst provider area/rolling-update labels Jul 8, 2026
@hakman hakman force-pushed the modernize-ptrto-new branch from 88c2813 to e707701 Compare July 8, 2026 05:15
@hakman

hakman commented Jul 8, 2026

Copy link
Copy Markdown
Member Author

/approve

@kubernetes-prow

kubernetes-prow Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubernetes-prow kubernetes-prow Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 8, 2026
@hakman

hakman commented Jul 8, 2026

Copy link
Copy Markdown
Member Author

/retest

@kubernetes-prow kubernetes-prow Bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 9, 2026
@hakman hakman force-pushed the modernize-ptrto-new branch from e707701 to 2bed1b1 Compare July 9, 2026 15:21
@kubernetes-prow kubernetes-prow Bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 9, 2026
@hakman

hakman commented Jul 9, 2026

Copy link
Copy Markdown
Member Author

/override pull-kops-e2e-cni-cilium-ipv6

@kubernetes-prow

kubernetes-prow Bot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

@hakman: Overrode contexts on behalf of hakman: pull-kops-e2e-cni-cilium-ipv6

Details

In response to this:

/override pull-kops-e2e-cni-cilium-ipv6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@hakman

hakman commented Jul 9, 2026

Copy link
Copy Markdown
Member Author

/override pull-kops-e2e-azure-cni-cilium

@kubernetes-prow

kubernetes-prow Bot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

@hakman: Overrode contexts on behalf of hakman: pull-kops-e2e-azure-cni-cilium

Details

In response to this:

/override pull-kops-e2e-azure-cni-cilium

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kubernetes-prow kubernetes-prow Bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 10, 2026
@hakman
Replace fi.PtrTo with new() builtin
3e3d4ce 
Signed-off-by: Ciprian Hacman <ciprian@hakman.dev>
@hakman hakman force-pushed the modernize-ptrto-new branch from 2bed1b1 to 3e3d4ce Compare July 10, 2026 04:37
@kubernetes-prow kubernetes-prow Bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 10, 2026
@ameukam

ameukam commented Jul 10, 2026

Copy link
Copy Markdown
Member

/lgtm

@kubernetes-prow kubernetes-prow Bot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 10, 2026
@hakman

hakman commented Jul 10, 2026

Copy link
Copy Markdown
Member Author

/override pull-kops-e2e-cni-cilium-ipv6

@kubernetes-prow

kubernetes-prow Bot commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

@hakman: Overrode contexts on behalf of hakman: pull-kops-e2e-cni-cilium-ipv6

Details

In response to this:

/override pull-kops-e2e-cni-cilium-ipv6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@hakman

hakman commented Jul 10, 2026

Copy link
Copy Markdown
Member Author

CSI tests flakes
/override pull-kops-e2e-gce-cni-calico
/override pull-kops-e2e-azure-cni-calico

@hakman hakman closed this Jul 10, 2026
@hakman hakman reopened this Jul 10, 2026
@hakman

hakman commented Jul 10, 2026

Copy link
Copy Markdown
Member Author

/test pull-kops-test

kubernetes-prow Bot added a commit that referenced this pull request Jul 10, 2026
@kubernetes-prow
Merge pull request #18551 from hakman/modernize-ptrto-new-1.36
62d0bf6 
Cherry pick of #18549: Replace fi.PtrTo with new() builtin
@hakman

hakman commented Jul 10, 2026

Copy link
Copy Markdown
Member Author

/override pull-kops-e2e-azure-cni-calico

@kubernetes-prow

kubernetes-prow Bot commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

@hakman: Overrode contexts on behalf of hakman: pull-kops-e2e-azure-cni-calico

Details

In response to this:

/override pull-kops-e2e-azure-cni-calico

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

kubernetes-prow Bot added a commit that referenced this pull request Jul 10, 2026
@kubernetes-prow
Merge pull request #18550 from hakman/modernize-ptrto-new-1.35
34c64b9 
Cherry pick of #18549: Replace fi.PtrTo with new() builtin
@hakman

hakman commented Jul 10, 2026

Copy link
Copy Markdown
Member Author

/retest

@kubernetes-prow kubernetes-prow Bot merged commit 5d8336e into kubernetes:master Jul 10, 2026
49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ameukam ameukam Awaiting requested review from ameukam
@rifelpet rifelpet Awaiting requested review from rifelpet

Assignees

@ameukam ameukam

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/api area/channels area/kops-controller area/nodeup area/provider/aws Issues or PRs related to aws provider area/provider/azure Issues or PRs related to azure provider area/provider/digitalocean Issues or PRs related to digitalocean provider area/provider/gcp Issues or PRs related to gcp provider area/provider/hetzner Issues or PRs related to Hetzner provider area/provider/openstack Issues or PRs related to openstack provider area/provider/scaleway Issues or PRs related to Scaleway provider area/provider/spotinst Issues or PRs related to spotinst provider area/rolling-update cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hakman @ameukam