nodeup: include Ubuntu in markSecondaryENIsUnmanaged guard

[ADoggg9]

nodeup: include Ubuntu in markSecondaryENIsUnmanaged guard

Add Ubuntu >= 22.04 to the guard clause so kops writes the
Unmanaged=yes .network file for secondary ENIs on Ubuntu, mirroring
the existing AL2023 / Debian 12+ handling. Without this, systemd-networkd
keeps DHCP-ing on secondary ENIs managed by Cilium / AWS VPC CNI.

Fixes #18564

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: ADoggg9 / name: ADoggg9 (13594ac)

[kubernetes-prow]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign hakman for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[kubernetes-prow]

Welcome @ADoggg9!

It looks like this is your first PR to kubernetes/kops 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kops has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[kubernetes-prow]

Hi @ADoggg9. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[hakman]

/cc @rifelpet

[hakman]

/ok-to-test

[hakman]

Suggested change

	(dist.IsDebian() && dist.Version() >= 12)) ||
	(dist.IsUbuntu() && dist.Version() >= 22.04) {
	(dist.IsDebian() && dist.Version() >= 12) ||
	(dist.IsUbuntu() && dist.Version() >= 22.04)) {

[ADoggg9]

Good catch — fixed in <4e27477d>. Thanks!

[ADoggg9]

@hakman hi，noticed nodeup/pkg/model/networking has no _test.go files today. Bootstrapping a test file from scratch (figuring out fi.NodeupModelBuilderContext construction + File task assertions) feels out of scope for this XS guard fix. If you want Ubuntu 22.04/24.04 test coverage, I'd prefer a separate follow-up PR — keep this one focused on the guard fix. Fine either way, let me know.