Automated cherry pick of #18567: dns-controller: always apply the addon, empty when unused#18570
Conversation
When a cluster does not use dns-controller (dns=none topology or the external-dns provider), the dns-controller addon was dropped from the bootstrap channel entirely. Channels never prunes addons that are no longer in the channel, so clusters migrating from gossip to dns=none were left with an orphaned dns-controller deployment that had to be deleted manually. Keep applying the dns-controller addon on every cluster, as a tombstone with an empty manifest and prune directives when it is unused, so that any previously deployed dns-controller resources are cleaned up automatically.
kubernetes-prow
Bot
added
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/cc @rifelpet |
|
@hakman: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
1 participant
Cherry pick of #18567 on release-1.36.
#18567: dns-controller: always apply the addon, empty when unused
For details on the cherry pick process, see the cherry pick requests page.
What type of PR is this?