Skip to content

Commit 0c927ad

Browse files
pierluigilenocihakman
authored andcommitted
fix: honor stderrthreshold on Windows entrypoint
The Unix entrypoint already sets legacy_stderr_threshold_behavior=false and stderrthreshold=INFO, but the Windows entrypoint was missed. klog v2 defaults -logtostderr to true. When active, -stderrthreshold is silently ignored — all log levels are unconditionally sent to stderr. Setting legacy_stderr_threshold_behavior=false enables the fix so that -stderrthreshold is honored even when -logtostderr=true. Ref: kubernetes/klog#212, kubernetes/klog#432 Signed-off-by: Pierluigi Lenoci <pierluigi.lenoci@gmail.com> Signed-off-by: Pierluigi Lenoci <pierluigilenoci@gmail.com>
1 parent cc85ca1 commit 0c927ad

1 file changed

Lines changed: 3 additions & 0 deletions

File tree

cmd/nodeproblemdetector/node_problem_detector_windows.go

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,9 @@ var (
4646
func main() {
4747
klogFlags := flag.NewFlagSet("klog", flag.ExitOnError)
4848
klog.InitFlags(klogFlags)
49+
// Opt into fixed stderrthreshold behavior (kubernetes/klog#212).
50+
_ = klogFlags.Set("legacy_stderr_threshold_behavior", "false")
51+
_ = klogFlags.Set("stderrthreshold", "INFO")
4952
klogFlags.VisitAll(func(f *flag.Flag) {
5053
switch f.Name {
5154
case "v", "vmodule", "logtostderr":

0 commit comments

Comments
 (0)