Skip to content

docs: Add versioning proposal#1087

Merged
k8s-ci-robot merged 1 commit into
kubernetes:masterfrom
SergeyKanzhelev:versioning-proposal
Aug 13, 2025
Merged

docs: Add versioning proposal#1087
k8s-ci-robot merged 1 commit into
kubernetes:masterfrom
SergeyKanzhelev:versioning-proposal

Conversation

@SergeyKanzhelev

@SergeyKanzhelev SergeyKanzhelev commented Aug 8, 2025

Copy link
Copy Markdown
Member

Proposal for #1062

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 8, 2025
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 8, 2025
@SergeyKanzhelev

SergeyKanzhelev commented Aug 9, 2025

Copy link
Copy Markdown
Member Author

/retest

1 similar comment
@hakman

hakman commented Aug 10, 2025

Copy link
Copy Markdown
Member

/retest

@SergeyKanzhelev SergeyKanzhelev mentioned this pull request Aug 11, 2025
Closed
hakman
hakman reviewed Aug 12, 2025
View reviewed changes
Comment thread docs/versioning.md Outdated
This new versioning scheme will provide the following benefits:

* **Clarity**: It will be immediately clear which version of Node Problem Detector is compatible with which version of Kubernetes.
* **Consistency**: It aligns the project with the release cycle of Kubernetes, which it is tightly coupled with.

@hakman hakman Aug 12, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know how tightly coupled NPD is with K8s, works fine with pretty well with most K8s versions.
Some tests with all supported K8s versions would be helpful in the future.

@SergeyKanzhelev SergeyKanzhelev Aug 12, 2025

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, shouldn't have said tightly coupled. At least not at this moment. The coupling is coming from the fact that the set of components running with the specific k8s version is typically locked and NPD works with them. So it is easier just keep specific version of NPD there and have all new features for never version of components in the new version

@hakman hakman Aug 13, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @SergeyKanzhelev. Before merging, could you remove the which it is tightly coupled with part?

@SergeyKanzhelev SergeyKanzhelev Aug 13, 2025

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@wangzhen127

wangzhen127 commented Aug 12, 2025

Copy link
Copy Markdown
Member

/lgtm
/hold

Pending @hakman's review.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 12, 2025
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 12, 2025
@wangzhen127

wangzhen127 commented Aug 12, 2025

Copy link
Copy Markdown
Member

cc @DigitalVeer

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 12, 2025
@SergeyKanzhelev

SergeyKanzhelev commented Aug 12, 2025

Copy link
Copy Markdown
Member Author

@wangzhen127 I updated the doc to reflect that we will call it v1

@wangzhen127

wangzhen127 commented Aug 12, 2025

Copy link
Copy Markdown
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 12, 2025
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 13, 2025
@hakman

hakman commented Aug 13, 2025

Copy link
Copy Markdown
Member

/lgtm
/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 13, 2025
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 13, 2025
@k8s-ci-robot

k8s-ci-robot commented Aug 13, 2025

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman, SergeyKanzhelev, wangzhen127

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [SergeyKanzhelev,wangzhen127]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hakman

hakman commented Aug 13, 2025

Copy link
Copy Markdown
Member

/test pull-npd-build

@k8s-ci-robot k8s-ci-robot merged commit f06867d into kubernetes:master Aug 13, 2025
14 checks passed
@SergeyKanzhelev SergeyKanzhelev deleted the versioning-proposal branch August 16, 2025 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hakman hakman hakman left review comments
@dchen1107 dchen1107 Awaiting requested review from dchen1107
@mrunalp mrunalp Awaiting requested review from mrunalp

Assignees

@wangzhen127 wangzhen127

@hakman hakman

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@SergeyKanzhelev @hakman @wangzhen127 @k8s-ci-robot