Skip to content

enable linter on repository#1088

Merged
k8s-ci-robot merged 1 commit into
kubernetes:masterfrom
SergeyKanzhelev:linter
Aug 13, 2025
Merged

enable linter on repository#1088
k8s-ci-robot merged 1 commit into
kubernetes:masterfrom
SergeyKanzhelev:linter

Conversation

@SergeyKanzhelev

Copy link
Copy Markdown
Member

this was all generated by gemini

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 8, 2025
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 8, 2025
@hakman

hakman commented Aug 10, 2025

Copy link
Copy Markdown
Member

/retest

@SergeyKanzhelev SergeyKanzhelev changed the title [WIP] enable linter on repository enable linter on repository Aug 13, 2025
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 13, 2025
@SergeyKanzhelev

Copy link
Copy Markdown
Member Author

/retest

Comment thread Makefile Outdated
@hakman

hakman commented Aug 13, 2025

Copy link
Copy Markdown
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 13, 2025
@k8s-ci-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman, SergeyKanzhelev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@SergeyKanzhelev

Copy link
Copy Markdown
Member Author

@hakman do you have permissions on this repo to try that new workflow .github/workflows/lint.yml once this merged?

@k8s-ci-robot k8s-ci-robot merged commit 414d248 into kubernetes:master Aug 13, 2025
15 checks passed
@SergeyKanzhelev SergeyKanzhelev deleted the linter branch August 13, 2025 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants