enabled and fixed the errcheck linter rule

[SergeyKanzhelev]

Errors:

./.bin/golangci-lint run --config .golangci.yml ./...
cmd/healthchecker/health_checker.go:42:30: Error return value of `pflag.CommandLine.MarkHidden` is not checked (errcheck)
        pflag.CommandLine.MarkHidden("vmodule")
                                    ^
cmd/healthchecker/health_checker.go:43:30: Error return value of `pflag.CommandLine.MarkHidden` is not checked (errcheck)
        pflag.CommandLine.MarkHidden("logtostderr")
                                    ^
cmd/healthchecker/options/options.go:55:20: Error return value of `fs.MarkDeprecated` is not checked (errcheck)
                fs.MarkDeprecated("systemd-service", "please use --service flag instead")
                                 ^
cmd/nodeproblemdetector/node_problem_detector_test.go:99:12: Error return value of `os.Remove` is not checked (errcheck)
                os.Remove(fileName)
                         ^
cmd/nodeproblemdetector/node_problem_detector_test.go:109:12: Error return value of `os.Remove` is not checked (errcheck)
                os.Remove(fakeLogFileName)
                         ^
cmd/nodeproblemdetector/node_problem_detector_test.go:117:12: Error return value of `os.Remove` is not checked (errcheck)
                os.Remove(fakeLogFileName)
                         ^
cmd/nodeproblemdetector/node_problem_detector_test.go:118:12: Error return value of `os.Remove` is not checked (errcheck)
                os.Remove(fakeConfigFileName)
                         ^
cmd/nodeproblemdetector/node_problem_detector_test.go:129:13: Error return value of `os.Remove` is not checked (errcheck)
                        os.Remove(fakeLogFileName)
                                 ^
cmd/nodeproblemdetector/node_problem_detector_test.go:130:13: Error return value of `os.Remove` is not checked (errcheck)
                        os.Remove(fakeConfigFileName)
                                 ^
cmd/nodeproblemdetector/node_problem_detector_unix.go:41:30: Error return value of `pflag.CommandLine.MarkHidden` is not checked (errcheck)
        pflag.CommandLine.MarkHidden("vmodule")
                                    ^
cmd/nodeproblemdetector/node_problem_detector_unix.go:42:30: Error return value of `pflag.CommandLine.MarkHidden` is not checked (errcheck)
        pflag.CommandLine.MarkHidden("logtostderr")
                                    ^
cmd/options/options.go:112:19: Error return value of `fs.MarkDeprecated` is not checked (errcheck)
        fs.MarkDeprecated("system-log-monitors", "replaced by --config.system-log-monitor. NPD will panic if both --system-log-monitors and --config.system-log-monitor are set.")
                         ^
cmd/options/options.go:115:19: Error return value of `fs.MarkDeprecated` is not checked (errcheck)
        fs.MarkDeprecated("custom-plugin-monitors", "replaced by --config.custom-plugin-monitor. NPD will panic if both --custom-plugin-monitors and --config.custom-plugin-monitor are set.")
                         ^
pkg/custompluginmonitor/plugin/plugin_test.go:106:30: Error return value of `(*k8s.io/node-problem-detector/pkg/custompluginmonitor/types.CustomPluginConfig).ApplyConfiguration` is not checked (errcheck)
                        (&conf).ApplyConfiguration()
                                                  ^
pkg/custompluginmonitor/types/config_test.go:222:36: Error return value of `(*k8s.io/node-problem-detector/pkg/custompluginmonitor/types.CustomPluginConfig).ApplyConfiguration` is not checked (errcheck)
                (&utMeta.Orig).ApplyConfiguration()
                                                 ^
pkg/exporters/k8sexporter/k8s_exporter.go:97:10: Error return value of `w.Write` is not checked (errcheck)
                w.Write([]byte("ok"))
                       ^
pkg/healthchecker/health_checker_linux.go:68:15: Error return value is not checked (errcheck)
                        execCommand(types.CmdTimeout, "pkill", "-SIGUSR1", "dockerd")
                                   ^
pkg/healthchecker/health_checker_linux.go:69:15: Error return value is not checked (errcheck)
                        execCommand(types.CmdTimeout, "systemctl", "kill", "--kill-who=main", hco.Service)
                                   ^
pkg/healthchecker/health_checker_linux.go:74:15: Error return value is not checked (errcheck)
                        execCommand(types.CmdTimeout, "systemctl", "kill", "--kill-who=main", hco.Service)
                                   ^
pkg/problemmetrics/problem_metrics_test.go:121:32: Error return value of `pmm.IncrementProblemCounter` is not checked (errcheck)
                                pmm.IncrementProblemCounter(reason, test.counts[idx])
                                                           ^
pkg/problemmetrics/problem_metrics_test.go:269:24: Error return value of `pmm.SetProblemGauge` is not checked (errcheck)
                                pmm.SetProblemGauge(argument.problemType, argument.reason, argument.value)
                                                   ^
pkg/systemlogmonitor/logwatchers/filelog/log_watcher.go:94:17: Error return value of `s.closer.Close` is not checked (errcheck)
                s.closer.Close()
                              ^
pkg/systemlogmonitor/logwatchers/filelog/log_watcher_test.go:144:11: Error return value of `f.Close` is not checked (errcheck)
                        f.Close()
                               ^
pkg/systemlogmonitor/logwatchers/filelog/log_watcher_test.go:145:13: Error return value of `os.Remove` is not checked (errcheck)
                        os.Remove(f.Name())
                                 ^
pkg/systemlogmonitor/logwatchers/kmsg/log_watcher_linux.go:80:20: Error return value of `k.kmsgParser.Close` is not checked (errcheck)
        k.kmsgParser.Close()
                          ^
pkg/systemstatsmonitor/cpu_collector.go:190:22: Error return value of `cc.mUsageTime.Record` is not checked (errcheck)
        cc.mUsageTime.Record(map[string]string{stateLabel: "user"}, clockTick*timersStat.User-cc.lastUsageTime["user"])
                            ^
pkg/systemstatsmonitor/cpu_collector.go:193:22: Error return value of `cc.mUsageTime.Record` is not checked (errcheck)
        cc.mUsageTime.Record(map[string]string{stateLabel: "system"}, clockTick*timersStat.System-cc.lastUsageTime["system"])
                            ^
pkg/systemstatsmonitor/cpu_collector.go:196:22: Error return value of `cc.mUsageTime.Record` is not checked (errcheck)
        cc.mUsageTime.Record(map[string]string{stateLabel: "idle"}, clockTick*timersStat.Idle-cc.lastUsageTime["idle"])
                            ^
pkg/systemstatsmonitor/cpu_collector.go:199:22: Error return value of `cc.mUsageTime.Record` is not checked (errcheck)
        cc.mUsageTime.Record(map[string]string{stateLabel: "nice"}, clockTick*timersStat.Nice-cc.lastUsageTime["nice"])
                            ^
pkg/systemstatsmonitor/cpu_collector.go:202:22: Error return value of `cc.mUsageTime.Record` is not checked (errcheck)
        cc.mUsageTime.Record(map[string]string{stateLabel: "iowait"}, clockTick*timersStat.Iowait-cc.lastUsageTime["iowait"])
                            ^
pkg/systemstatsmonitor/cpu_collector.go:205:22: Error return value of `cc.mUsageTime.Record` is not checked (errcheck)
        cc.mUsageTime.Record(map[string]string{stateLabel: "irq"}, clockTick*timersStat.Irq-cc.lastUsageTime["irq"])
                            ^
pkg/systemstatsmonitor/cpu_collector.go:208:22: Error return value of `cc.mUsageTime.Record` is not checked (errcheck)
        cc.mUsageTime.Record(map[string]string{stateLabel: "softirq"}, clockTick*timersStat.Softirq-cc.lastUsageTime["softirq"])
                            ^
pkg/systemstatsmonitor/cpu_collector.go:211:22: Error return value of `cc.mUsageTime.Record` is not checked (errcheck)
        cc.mUsageTime.Record(map[string]string{stateLabel: "steal"}, clockTick*timersStat.Steal-cc.lastUsageTime["steal"])
                            ^
pkg/systemstatsmonitor/cpu_collector.go:214:22: Error return value of `cc.mUsageTime.Record` is not checked (errcheck)
        cc.mUsageTime.Record(map[string]string{stateLabel: "guest"}, clockTick*timersStat.Guest-cc.lastUsageTime["guest"])
                            ^
pkg/systemstatsmonitor/cpu_collector.go:217:22: Error return value of `cc.mUsageTime.Record` is not checked (errcheck)
        cc.mUsageTime.Record(map[string]string{stateLabel: "guest_nice"}, clockTick*timersStat.GuestNice-cc.lastUsageTime["guest_nice"])
                            ^
pkg/systemstatsmonitor/cpu_collector_unix.go:43:31: Error return value of `cc.mRunnableTaskCount.Record` is not checked (errcheck)
                cc.mRunnableTaskCount.Record(map[string]string{}, loadAvg.Load1)
                                            ^
pkg/systemstatsmonitor/cpu_collector_unix.go:46:23: Error return value of `cc.mCpuLoad1m.Record` is not checked (errcheck)
                cc.mCpuLoad1m.Record(map[string]string{}, loadAvg.Load1)
                                    ^
pkg/systemstatsmonitor/cpu_collector_unix.go:49:23: Error return value of `cc.mCpuLoad5m.Record` is not checked (errcheck)
                cc.mCpuLoad5m.Record(map[string]string{}, loadAvg.Load5)
                                    ^
pkg/systemstatsmonitor/cpu_collector_unix.go:52:24: Error return value of `cc.mCpuLoad15m.Record` is not checked (errcheck)
                cc.mCpuLoad15m.Record(map[string]string{}, loadAvg.Load15)
                                     ^
pkg/systemstatsmonitor/cpu_collector_unix.go:76:34: Error return value of `cc.mSystemProcessesTotal.Record` is not checked (errcheck)
                cc.mSystemProcessesTotal.Record(map[string]string{}, int64(stats.ProcessCreated))
                                               ^
pkg/systemstatsmonitor/cpu_collector_unix.go:80:32: Error return value of `cc.mSystemProcsRunning.Record` is not checked (errcheck)
                cc.mSystemProcsRunning.Record(map[string]string{}, int64(stats.ProcessesRunning))
                                             ^
pkg/systemstatsmonitor/cpu_collector_unix.go:84:32: Error return value of `cc.mSystemProcsBlocked.Record` is not checked (errcheck)
                cc.mSystemProcsBlocked.Record(map[string]string{}, int64(stats.ProcessesBlocked))
                                             ^
pkg/systemstatsmonitor/cpu_collector_unix.go:88:35: Error return value of `cc.mSystemInterruptsTotal.Record` is not checked (errcheck)
                cc.mSystemInterruptsTotal.Record(map[string]string{}, int64(stats.IRQTotal))
                                                ^
pkg/systemstatsmonitor/cpu_collector_unix.go:97:28: Error return value of `cc.mSystemCPUStat.Record` is not checked (errcheck)
                        cc.mSystemCPUStat.Record(tags, c.User)
                                                ^
pkg/systemstatsmonitor/cpu_collector_unix.go:99:28: Error return value of `cc.mSystemCPUStat.Record` is not checked (errcheck)
                        cc.mSystemCPUStat.Record(tags, c.Nice)
                                                ^
pkg/systemstatsmonitor/cpu_collector_unix.go:101:28: Error return value of `cc.mSystemCPUStat.Record` is not checked (errcheck)
                        cc.mSystemCPUStat.Record(tags, c.System)
                                                ^
pkg/systemstatsmonitor/cpu_collector_unix.go:103:28: Error return value of `cc.mSystemCPUStat.Record` is not checked (errcheck)
                        cc.mSystemCPUStat.Record(tags, c.Idle)
                                                ^
pkg/systemstatsmonitor/cpu_collector_unix.go:105:28: Error return value of `cc.mSystemCPUStat.Record` is not checked (errcheck)
                        cc.mSystemCPUStat.Record(tags, c.Iowait)
                                                ^
pkg/systemstatsmonitor/cpu_collector_unix.go:107:28: Error return value of `cc.mSystemCPUStat.Record` is not checked (errcheck)
                        cc.mSystemCPUStat.Record(tags, c.IRQ)
                                                ^
pkg/systemstatsmonitor/cpu_collector_unix.go:109:28: Error return value of `cc.mSystemCPUStat.Record` is not checked (errcheck)
                        cc.mSystemCPUStat.Record(tags, c.SoftIRQ)
                                                ^
pkg/systemstatsmonitor/cpu_collector_unix.go:111:28: Error return value of `cc.mSystemCPUStat.Record` is not checked (errcheck)
                        cc.mSystemCPUStat.Record(tags, c.Steal)
                                                ^
pkg/systemstatsmonitor/cpu_collector_unix.go:113:28: Error return value of `cc.mSystemCPUStat.Record` is not checked (errcheck)
                        cc.mSystemCPUStat.Record(tags, c.Guest)
                                                ^
pkg/systemstatsmonitor/cpu_collector_unix.go:115:28: Error return value of `cc.mSystemCPUStat.Record` is not checked (errcheck)
                        cc.mSystemCPUStat.Record(tags, c.GuestNice)
                                                ^
pkg/systemstatsmonitor/disk_collector.go:191:21: Error return value of `dc.mIOTime.Record` is not checked (errcheck)
                        dc.mIOTime.Record(tags, int64(ioCountersStat.IoTime-lastIOTime))
                                         ^
pkg/systemstatsmonitor/disk_collector.go:194:25: Error return value of `dc.mWeightedIO.Record` is not checked (errcheck)
                        dc.mWeightedIO.Record(tags, int64(ioCountersStat.WeightedIO-lastWeightedIO))
                                             ^
pkg/systemstatsmonitor/disk_collector.go:203:27: Error return value of `dc.mAvgQueueLen.Record` is not checked (errcheck)
                                dc.mAvgQueueLen.Record(tags, avgQueueLen)
                                                      ^
pkg/systemstatsmonitor/disk_collector.go:211:23: Error return value of `dc.mOpsCount.Record` is not checked (errcheck)
                        dc.mOpsCount.Record(tags, int64(ioCountersStat.ReadCount-dc.lastReadCount[deviceName]))
                                           ^
pkg/systemstatsmonitor/disk_collector.go:215:29: Error return value of `dc.mMergedOpsCount.Record` is not checked (errcheck)
                        dc.mMergedOpsCount.Record(tags, int64(ioCountersStat.MergedReadCount-dc.lastMergedReadCount[deviceName]))
                                                 ^
pkg/systemstatsmonitor/disk_collector.go:219:23: Error return value of `dc.mOpsBytes.Record` is not checked (errcheck)
                        dc.mOpsBytes.Record(tags, int64(ioCountersStat.ReadBytes-dc.lastReadBytes[deviceName]))
                                           ^
pkg/systemstatsmonitor/disk_collector.go:223:22: Error return value of `dc.mOpsTime.Record` is not checked (errcheck)
                        dc.mOpsTime.Record(tags, int64(ioCountersStat.ReadTime-dc.lastReadTime[deviceName]))
                                          ^
pkg/systemstatsmonitor/disk_collector.go:231:23: Error return value of `dc.mOpsCount.Record` is not checked (errcheck)
                        dc.mOpsCount.Record(tags, int64(ioCountersStat.WriteCount-dc.lastWriteCount[deviceName]))
                                           ^
pkg/systemstatsmonitor/disk_collector.go:235:29: Error return value of `dc.mMergedOpsCount.Record` is not checked (errcheck)
                        dc.mMergedOpsCount.Record(tags, int64(ioCountersStat.MergedWriteCount-dc.lastMergedWriteCount[deviceName]))
                                                 ^
pkg/systemstatsmonitor/disk_collector.go:239:23: Error return value of `dc.mOpsBytes.Record` is not checked (errcheck)
                        dc.mOpsBytes.Record(tags, int64(ioCountersStat.WriteBytes-dc.lastWriteBytes[deviceName]))
                                           ^
pkg/systemstatsmonitor/disk_collector.go:243:22: Error return value of `dc.mOpsTime.Record` is not checked (errcheck)
                        dc.mOpsTime.Record(tags, int64(ioCountersStat.WriteTime-dc.lastWriteTime[deviceName]))
                                          ^
pkg/systemstatsmonitor/disk_collector.go:304:23: Error return value of `dc.mBytesUsed.Record` is not checked (errcheck)
                dc.mBytesUsed.Record(map[string]string{deviceNameLabel: deviceName, fsTypeLabel: fstype, mountOptionLabel: opttypes, stateLabel: "free"}, int64(usageStat.Free))
                                    ^
pkg/systemstatsmonitor/disk_collector.go:305:23: Error return value of `dc.mBytesUsed.Record` is not checked (errcheck)
                dc.mBytesUsed.Record(map[string]string{deviceNameLabel: deviceName, fsTypeLabel: fstype, mountOptionLabel: opttypes, stateLabel: "used"}, int64(usageStat.Used))
                                    ^
pkg/systemstatsmonitor/disk_collector.go:307:26: Error return value of `dc.mPercentUsed.Record` is not checked (errcheck)
                        dc.mPercentUsed.Record(map[string]string{deviceNameLabel: deviceName, fsTypeLabel: fstype, mountOptionLabel: opttypes, stateLabel: "used"}, float64(usageStat.UsedPercent))
                                              ^
pkg/systemstatsmonitor/host_collector.go:77:19: Error return value of `hc.uptime.Record` is not checked (errcheck)
                hc.uptime.Record(hc.tags, int64(uptime))
                                ^
pkg/systemstatsmonitor/memory_collector_unix.go:44:24: Error return value of `mc.mBytesUsed.Record` is not checked (errcheck)
                        mc.mBytesUsed.Record(map[string]string{stateLabel: "free"}, int64(*meminfo.MemFree)*1024)
                                            ^
pkg/systemstatsmonitor/memory_collector_unix.go:47:24: Error return value of `mc.mBytesUsed.Record` is not checked (errcheck)
                        mc.mBytesUsed.Record(map[string]string{stateLabel: "buffered"}, int64(*meminfo.Buffers)*1024)
                                            ^
pkg/systemstatsmonitor/memory_collector_unix.go:50:24: Error return value of `mc.mBytesUsed.Record` is not checked (errcheck)
                        mc.mBytesUsed.Record(map[string]string{stateLabel: "cached"}, int64(*meminfo.Cached)*1024)
                                            ^
pkg/systemstatsmonitor/memory_collector_unix.go:53:24: Error return value of `mc.mBytesUsed.Record` is not checked (errcheck)
                        mc.mBytesUsed.Record(map[string]string{stateLabel: "slab"}, int64(*meminfo.Slab)*1024)
                                            ^
pkg/systemstatsmonitor/memory_collector_unix.go:57:24: Error return value of `mc.mBytesUsed.Record` is not checked (errcheck)
                        mc.mBytesUsed.Record(map[string]string{stateLabel: "used"}, int64(memUsed)*1024)
                                            ^
pkg/systemstatsmonitor/memory_collector_unix.go:64:25: Error return value of `mc.mPercentUsed.Record` is not checked (errcheck)
                mc.mPercentUsed.Record(map[string]string{stateLabel: "used"}, float64(ratio*100.0))
                                      ^
pkg/systemstatsmonitor/memory_collector_unix.go:69:24: Error return value of `mc.mDirtyUsed.Record` is not checked (errcheck)
                        mc.mDirtyUsed.Record(map[string]string{stateLabel: "dirty"}, int64(*meminfo.Dirty)*1024)
                                            ^
pkg/systemstatsmonitor/memory_collector_unix.go:72:24: Error return value of `mc.mDirtyUsed.Record` is not checked (errcheck)
                        mc.mDirtyUsed.Record(map[string]string{stateLabel: "writeback"}, int64(*meminfo.Writeback)*1024)
                                            ^
pkg/systemstatsmonitor/memory_collector_unix.go:78:28: Error return value of `mc.mAnonymousUsed.Record` is not checked (errcheck)
                        mc.mAnonymousUsed.Record(map[string]string{stateLabel: "active"}, int64(*meminfo.ActiveAnon)*1024)
                                                ^
pkg/systemstatsmonitor/memory_collector_unix.go:81:28: Error return value of `mc.mAnonymousUsed.Record` is not checked (errcheck)
                        mc.mAnonymousUsed.Record(map[string]string{stateLabel: "inactive"}, int64(*meminfo.InactiveAnon)*1024)
                                                ^
pkg/systemstatsmonitor/memory_collector_unix.go:87:28: Error return value of `mc.mPageCacheUsed.Record` is not checked (errcheck)
                        mc.mPageCacheUsed.Record(map[string]string{stateLabel: "active"}, int64(*meminfo.ActiveFile)*1024)
                                                ^
pkg/systemstatsmonitor/memory_collector_unix.go:90:28: Error return value of `mc.mPageCacheUsed.Record` is not checked (errcheck)
                        mc.mPageCacheUsed.Record(map[string]string{stateLabel: "inactive"}, int64(*meminfo.InactiveFile)*1024)
                                                ^
pkg/systemstatsmonitor/memory_collector_unix.go:95:29: Error return value of `mc.mUnevictableUsed.Record` is not checked (errcheck)
                mc.mUnevictableUsed.Record(map[string]string{}, int64(*meminfo.Unevictable)*1024)
                                          ^
pkg/systemstatsmonitor/net_collector.go:290:26: Error return value of `collector.metric.Record` is not checked (errcheck)
                collector.metric.Record(tags, measurement)
                                       ^
pkg/systemstatsmonitor/osfeature_collector.go:89:22: Error return value of `ofc.osFeature.Record` is not checked (errcheck)
        ofc.osFeature.Record(map[string]string{featureLabel: "KTD"}, featuresMap["KTD"])
                            ^
pkg/systemstatsmonitor/osfeature_collector.go:90:22: Error return value of `ofc.osFeature.Record` is not checked (errcheck)
        ofc.osFeature.Record(map[string]string{featureLabel: "UnifiedCgroupHierarchy"}, featuresMap["UnifiedCgroupHierarchy"])
                            ^
pkg/systemstatsmonitor/osfeature_collector.go:92:23: Error return value of `ofc.osFeature.Record` is not checked (errcheck)
                ofc.osFeature.Record(map[string]string{featureLabel: "KernelModuleIntegrity"}, 1)
                                    ^
pkg/systemstatsmonitor/osfeature_collector.go:94:23: Error return value of `ofc.osFeature.Record` is not checked (errcheck)
                ofc.osFeature.Record(map[string]string{featureLabel: "KernelModuleIntegrity"}, 0)
                                    ^
pkg/systemstatsmonitor/osfeature_collector.go:140:23: Error return value of `ofc.osFeature.Record` is not checked (errcheck)
                ofc.osFeature.Record(map[string]string{
                                    ^
pkg/systemstatsmonitor/osfeature_collector.go:145:23: Error return value of `ofc.osFeature.Record` is not checked (errcheck)
                ofc.osFeature.Record(map[string]string{featureLabel: "UnknownModules"},
                                    ^
pkg/systemstatsmonitor/osfeature_collector.go:148:22: Error return value of `ofc.osFeature.Record` is not checked (errcheck)
        ofc.osFeature.Record(map[string]string{featureLabel: "GPUSupport"},
                            ^
pkg/util/http.go:33:9: Error return value of `w.Write` is not checked (errcheck)
        w.Write(data)
               ^
pkg/util/http.go:39:9: Error return value of `w.Write` is not checked (errcheck)
        w.Write([]byte(err.Error()))
               ^
pkg/util/metrics/fakes_test.go:235:18: Error return value of `metric.Record` is not checked (errcheck)
                                metric.Record(record.tags, record.measurement)
                                             ^
pkg/util/metrics/metric_float64.go:75:15: Error return value of `view.Register` is not checked (errcheck)
        view.Register(newView)
                     ^
pkg/util/metrics/metric_int64.go:75:15: Error return value of `view.Register` is not checked (errcheck)
        view.Register(newView)
                     ^
pkg/util/metrics/system/common.go:27:18: Error return value of `file.Close` is not checked (errcheck)
        defer file.Close()
                        ^
95 issues:
* errcheck: 95
make: *** [Makefile:120: lint] Error 1

[hakman]

/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman, SergeyKanzhelev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [SergeyKanzhelev]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment