Skip to content

Add hakman as an approver#1121

Merged
k8s-ci-robot merged 5 commits into
kubernetes:masterfrom
hakman:hakman-approver
Sep 12, 2025
Merged

Add hakman as an approver#1121
k8s-ci-robot merged 5 commits into
kubernetes:masterfrom
hakman:hakman-approver

Conversation

@hakman

@hakman hakman commented Sep 11, 2025

Copy link
Copy Markdown
Member

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. and removed do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. labels Sep 11, 2025
@hakman

hakman commented Sep 11, 2025

Copy link
Copy Markdown
Member Author

@vteratipally doesn't seem to be a member of the org anymore, see kubernetes/org#5665.

SergeyKanzhelev
SergeyKanzhelev reviewed Sep 11, 2025
View reviewed changes
Comment thread OWNERS
- andyxning
- wangzhen127
- xueweiz
- vteratipally No newline at end of file

@SergeyKanzhelev SergeyKanzhelev Sep 11, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's introduce emeritus here?

@hakman hakman Sep 11, 2025

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

SergeyKanzhelev
SergeyKanzhelev reviewed Sep 11, 2025
View reviewed changes
Comment thread OWNERS
@hakman @SergeyKanzhelev
Add emeritus
60f41e7 
Co-authored-by: Sergey Kanzhelev <S.Kanzhelev@live.com>
@k8s-ci-robot k8s-ci-robot added the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Sep 11, 2025
k8s-ci-robot
k8s-ci-robot reviewed Sep 11, 2025
View reviewed changes

@k8s-ci-robot k8s-ci-robot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hakman: 1 invalid OWNERS file

Details

In response to this:

/cc @wangzhen127 @SergeyKanzhelev

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Comment thread OWNERS
@@ -3,12 +3,14 @@ reviewers:
- andyxning

@k8s-ci-robot k8s-ci-robot Sep 11, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cannot parse file: error converting YAML to JSON: yaml: line 13: did not find expected '-' indicator.

hakman
hakman commented Sep 11, 2025
View reviewed changes
Comment thread OWNERS Outdated
k8s-ci-robot
k8s-ci-robot reviewed Sep 11, 2025
View reviewed changes

@k8s-ci-robot k8s-ci-robot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hakman: 1 invalid OWNERS file

Details

In response to this:

/cc @wangzhen127 @SergeyKanzhelev

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Comment thread OWNERS
@@ -3,12 +3,13 @@ reviewers:
- andyxning

@k8s-ci-robot k8s-ci-robot Sep 11, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cannot parse file: error converting YAML to JSON: yaml: line 13: did not find expected '-' indicator.

hakman
hakman commented Sep 11, 2025
View reviewed changes
Comment thread OWNERS Outdated
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Sep 11, 2025
SergeyKanzhelev
SergeyKanzhelev reviewed Sep 11, 2025
View reviewed changes

@SergeyKanzhelev SergeyKanzhelev left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/hold

Let's wait for more +1's from other approvers

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 11, 2025
@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 11, 2025
@wangzhen127

wangzhen127 commented Sep 11, 2025

Copy link
Copy Markdown
Member

/lgtm

Thanks for all your effort! @hakman

@k8s-ci-robot

k8s-ci-robot commented Sep 11, 2025

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman, SergeyKanzhelev, wangzhen127

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [SergeyKanzhelev,wangzhen127]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hakman hakman added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Sep 12, 2025
@hakman

hakman commented Sep 12, 2025

Copy link
Copy Markdown
Member Author

Thank you both 🙂
/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 12, 2025
@k8s-ci-robot k8s-ci-robot merged commit 3fb81ae into kubernetes:master Sep 12, 2025
15 checks passed
@hakman hakman mentioned this pull request Sep 12, 2025
Merged
k8s-ci-robot pushed a commit that referenced this pull request Sep 12, 2025
@hakman @SergeyKanzhelev
Automated cherry pick of #1121: Add hakman as an approver (#1125)
02561d8 
* Add hakman as an approver

* Remove vteratipally

* Add emeritus

Co-authored-by: Sergey Kanzhelev <S.Kanzhelev@live.com>

* Update OWNERS

* Update OWNERS

---------

Co-authored-by: Sergey Kanzhelev <S.Kanzhelev@live.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@k8s-ci-robot k8s-ci-robot k8s-ci-robot left review comments
@wangzhen127 wangzhen127 Awaiting requested review from wangzhen127
+1 more reviewer
@SergeyKanzhelev SergeyKanzhelev SergeyKanzhelev left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@wangzhen127 wangzhen127

@SergeyKanzhelev SergeyKanzhelev

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@hakman @wangzhen127 @k8s-ci-robot @SergeyKanzhelev