Update Cloud Build config#1123
Merged
Merged
Conversation
k8s-ci-robot
requested review from
SergeyKanzhelev,
ameukam and
wangzhen127
k8s-ci-robot
added
cncf-cla: yes
Member
Author
|
/hold for the prerequisites to be merged |
k8s-ci-robot
added
the
do-not-merge/hold
hakman
force-pushed
the
update-cloud-build
branch
from
f5ea71c to
b9dcdf8
Compare
hakman
force-pushed
the
update-cloud-build
branch
from
b9dcdf8 to
a5c6501
Compare
Member
Author
|
/retest |
Member
Author
|
Should work ok now, the remaining prerequisite is just nice to have. |
k8s-ci-robot
removed
the
do-not-merge/hold
ameukam
reviewed
Sep 11, 2025
| - PULL_BASE_REF=$_PULL_BASE_REF | ||
| - VERSION=$_PULL_BASE_REF | ||
| - DOCKER_CLI_EXPERIMENTAL=enabled | ||
| - name: 'gcr.io/cloud-builders/docker' |
Member
There was a problem hiding this comment.
Do we know if this image support buildx ?
k8s-ci-robot
added
lgtm
Member
|
/lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ameukam, hakman, SergeyKanzhelev The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should allow us to use the images that are built by
node-problem-detector-push-imagesand pushed togcr.io/k8s-staging-npd.This requires #1122 and kubernetes/test-infra#35512.
/cc @SergeyKanzhelev @wangzhen127 @ameukam