feat(exporters): replace opencensus with opentelemetry#1297
Open
hakman wants to merge 18 commits into
Open
Conversation
Contributor
|
@hakman: GitHub didn't allow me to request PR reviews from the following users: daveoy. Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
kubernetes-prow
Bot
added
the
cncf-cla: yes
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hakman The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubernetes-prow
Bot
added
approved
hakman
force-pushed
the
pr-1141-fixes
branch
5 times, most recently
from
a537ec6 to
ee90453
Compare
Member
Author
|
/test pull-npd-e2e-test |
kubernetes-prow
Bot
added
the
needs-rebase
kubernetes-prow
Bot
removed
the
needs-rebase
hakman
force-pushed
the
pr-1141-fixes
branch
3 times, most recently
from
8284a46 to
a12139a
Compare
* feat(exporters): replace opencensus with opentelemetry * fix(stackdriver_exporter): use metrics util constants * chore: use global meter and init * feat(exporters): add resource info, use global meter * chore: update deps * fix: use a gauge directly, narrow scope info * cleanup: deps * fix: try initOnce pattern for global problem metrics * fix(problemmetrics): init is being called too late * fix(gauge): remove _ratio suffix * fix: clean up after rebase * fix: cleanup after rebase * fix: cleanup after rebase * fix: cleanup after rebase * fix: remove nodename * fix(test): remove instance id check * fix(test): add attr values * fix(test): unexported resources * fix(test): initialize global problem metrics manager * fix(lint): make the linter happy
disk_percent_used declared only device_name but recorded four labels (device_name, fs_type, mount_option, state). With per-metric label validation, Record now rejects the undeclared labels and the metric is dropped from the export (caught by the metriconly e2e). Record only device_name, preserving the schema NPD has exported since the metric was introduced: the OpenCensus view aggregated by device_name and dropped the other tags, so on the wire this metric has always had a single label. It also maps to the Google-owned compute.googleapis.com/guest/disk/percent_used descriptor, which can reject writes carrying undeclared label keys. Add a regression test pinning the schema.
hakman
added
the
tide/merge-method-squash
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on @daveoy's #1141, adding remaining fixes.
Closes #1008
/cc @SergeyKanzhelev @wangzhen127