Skip to content

Commit 1b9df15

Browse files
chore: update Playwright to 1.60 (#2415)
* chore: update pw to 1.60 Resolves: None Signed-off-by: Pedro Abreu <pabreu@redhat.com> * chore: adopt PW 1.59/1.60 config improvements - Use retain-on-failure-and-retries for traces so all retry attempts are kept, not just the last one (useful with 3 retries on GITHUB_ACTIONS) - Expand video config to object form with show.actions so failure videos have visual action highlights (helpful for long migration tests) Resolves: None Signed-off-by: Pedro Abreu <pabreu@redhat.com> --------- Signed-off-by: Pedro Abreu <pabreu@redhat.com>
1 parent 640e3e7 commit 1b9df15

5 files changed

Lines changed: 24 additions & 19 deletions

File tree

testing/PlaywrightContainerFile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
FROM mcr.microsoft.com/playwright:v1.59.0-noble
1+
FROM mcr.microsoft.com/playwright:v1.60.0-noble
22

33
ARG GIT_COMMIT=unknown
44
ARG BUILD_DATE=unknown

testing/package-lock.json

Lines changed: 13 additions & 13 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

testing/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,9 +15,9 @@
1515
"license": "ISC",
1616
"description": "",
1717
"devDependencies": {
18-
"@playwright/test": "^1.59.0",
18+
"@playwright/test": "^1.60.0",
1919
"@types/node": "^20.0.0",
20-
"playwright": "^1.59.1",
20+
"playwright": "^1.60.0",
2121
"typescript": "^5.8.2"
2222
},
2323
"dependencies": {

testing/playwright.config.ts

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,8 +39,13 @@ export default defineConfig({
3939
headless: true,
4040
viewport: { width: 1920, height: 1080 },
4141
screenshot: 'only-on-failure',
42-
video: 'retain-on-failure',
43-
trace: 'retain-on-failure',
42+
video: {
43+
mode: 'retain-on-failure',
44+
show: {
45+
actions: { position: 'top-right' },
46+
},
47+
},
48+
trace: 'retain-on-failure-and-retries',
4449
// Use data-testid to match actual rendered HTML
4550
testIdAttribute: 'data-testid',
4651
ignoreHTTPSErrors: true,

testing/run-e2e-docker.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,5 +17,5 @@ docker run --rm -it \
1717
--env LC_ALL=en_US.UTF-8 \
1818
--env LANG=en_US.UTF-8 \
1919
--env LANGUAGE=en_US.UTF-8 \
20-
mcr.microsoft.com/playwright:v1.59.0-noble \
20+
mcr.microsoft.com/playwright:v1.60.0-noble \
2121
bash -c "npm install && npx playwright test --grep @downstream"

0 commit comments

Comments
 (0)