Skip to content

Nikhil/linkfix - #1266

Closed
nikhilchauhangithub wants to merge 2 commits into
kubevela:mainfrom
nikhilchauhangithub:Nikhil/Linkfix
Closed

Nikhil/linkfix#1266
nikhilchauhangithub wants to merge 2 commits into
kubevela:mainfrom
nikhilchauhangithub:Nikhil/Linkfix

Conversation

@nikhilchauhangithub

Copy link
Copy Markdown
Contributor

Description of your changes

fix the standalone and Kubernetes hyperlink on the page https://kubevela.io/docs/install
"Fixes #6238":

I have:

  • [ x] Read and followed KubeVela's contribution process.
  • [x ] Update sidebar.js if adding a new page.
  • [x ] Run yarn start to ensure the changes has taken effect.

-->

Signed-off-by: nikhilchauhangithub <thisisnikhilchauhan@gmail.com>
Signed-off-by: nikhilchauhangithub <thisisnikhilchauhan@gmail.com>
@wonderflow

Copy link
Copy Markdown
Contributor

Hi @Arhell , do you know how to reduce the changes in yarn.lock?

@Arhell Arhell left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR does not need to update dependencies, there is another one for this #1261

I personally use this https://www.npmjs.com/package/npm-check-updates

@chivalryq

Copy link
Copy Markdown
Member

Both links here works well in Edge:

image

And I tried several times, found if I open https://kubevela.io/docs/install/ directly and the link is broken. However, if I go to this page by

  1. Open https://kubevela.io/docs/
  2. Click Installation

Then it works well. Do you have any ideas about this @Arhell? Before it is clear we should pend this PR.

@chivalryq

Copy link
Copy Markdown
Member

Related: #1268 Closing this PR because this is not the root problem.

@chivalryq chivalryq closed this Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants