fix: remove false duplicate shortcut errors across different groups

Form validation was checking shortcuts globally using flattenCommands(), causing false duplicate errors for shortcuts in completely separate groups.

Shortcuts only need to be unique within the same group (QuickPick menu), so form-level validation is removed and delegated to runtime validation in command-executor.ts which correctly scopes validation per group.

Author: kubrickcode

src/view/src/components/command-form-dialog.tsx

@@ -14,12 +14,10 @@ import {
 
 import { CommandForm } from "./command-form";
 import { useCommandForm } from "../context/command-form-context.tsx";
-import { useVscodeCommand } from "../context/vscode-command-context.tsx";
 
 export const CommandFormDialog = () => {
   const { t } = useTranslation();
   const { closeForm, editingCommand, handleSave, resetFormState, showForm } = useCommandForm();
-  const { commands } = useVscodeCommand();
   const formId = useId();
 
   const handleOpenChange = (open: boolean) => {
@@ -50,12 +48,7 @@ export const CommandFormDialog = () => {
           </DialogDescription>
         </DialogHeader>
         <DialogBody>
-          <CommandForm
-            command={editingCommand}
-            commands={commands}
-            formId={formId}
-            onSave={handleSave}
-          />
+          <CommandForm command={editingCommand} formId={formId} onSave={handleSave} />
         </DialogBody>
         <DialogFooter>
           <Button onClick={closeForm} type="button" variant="outline">

src/view/src/components/command-form.tsx

@@ -35,7 +35,6 @@ import { parseVSCodeIconName } from "../utils/parse-vscode-icon-name";
 
 type CommandFormProps = {
   command?: (ButtonConfig & { index?: number }) | null;
-  commands: ButtonConfig[];
   formId?: string;
   onSave: (command: ButtonConfig) => void;
 };
@@ -68,13 +67,12 @@ const buildCommandConfig = (data: ButtonConfigDraft, isGroup: boolean): ButtonCo
   return isGroup ? toGroupButton(normalized) : toCommandButton(normalized);
 };
 
-export const CommandForm = ({ command, commands, formId, onSave }: CommandFormProps) => {
+export const CommandForm = ({ command, formId, onSave }: CommandFormProps) => {
   const { t } = useTranslation();
 
-  const schema = useMemo(
-    () => createCommandFormSchema(commands, command?.id),
-    [commands, command?.id]
-  );
+  // Note: Shortcut uniqueness validation is handled at runtime in command-executor.ts
+  // Shortcuts only need to be unique within the same group (QuickPick menu)
+  const schema = useMemo(() => createCommandFormSchema(), []);
 
   const {
     control,

src/view/src/schemas/command-form-schema.ts

@@ -2,9 +2,6 @@ import { z } from "zod";
 
 import { type ButtonConfig } from "../types";
 
-export const getDuplicateShortcutErrorMessage = (shortcut: string) =>
-  `Shortcut "${shortcut}" is already used by another command`;
-
 /**
  * Type assertion for Zod v4 recursive schema constraints
  *
@@ -35,14 +32,7 @@ const buttonConfigSchema = z.lazy(() =>
   })
 ) as unknown as z.ZodType<ButtonConfig>;
 
-const flattenCommands = (cmds: ButtonConfig[]): ButtonConfig[] => {
-  return cmds.flatMap((cmd) => (cmd.group ? [cmd, ...flattenCommands(cmd.group)] : [cmd]));
-};
-
-export const createCommandFormSchema = (
-  commands: ButtonConfig[],
-  editingCommandId?: string
-): z.ZodType<ButtonConfig> => {
+export const createCommandFormSchema = (): z.ZodType<ButtonConfig> => {
   return z.object({
     color: z.string().optional(),
     command: z.string().optional(),
@@ -51,29 +41,7 @@ export const createCommandFormSchema = (
     id: z.string(),
     insertOnly: z.boolean().optional(),
     name: z.string().min(1, "Command name is required"),
-    shortcut: z
-      .string()
-      .optional()
-      .superRefine((value, ctx) => {
-        if (!value || !value.trim()) return;
-
-        const normalizedShortcut = value.toLowerCase().trim();
-        const allCommands = flattenCommands(commands);
-
-        const isDuplicate = allCommands.some((cmd) => {
-          if (editingCommandId !== undefined && cmd.id === editingCommandId) {
-            return false;
-          }
-          return cmd.shortcut?.toLowerCase().trim() === normalizedShortcut;
-        });
-
-        if (isDuplicate) {
-          ctx.addIssue({
-            code: "custom",
-            message: getDuplicateShortcutErrorMessage(value),
-          });
-        }
-      }),
+    shortcut: z.string().optional(),
     terminalName: z.string().optional(),
     useVsCodeApi: z.boolean().optional(),
   }) as unknown as z.ZodType<ButtonConfig>;