fix: Normalize TMPDIR paths in wrapper (#6)

Author: kuitos

.github/workflows/ci.yml

@@ -0,0 +1,24 @@
+name: CI
+
+on:
+  pull_request:
+  push:
+    branches: [main]
+
+jobs:
+  test:
+    runs-on: ubuntu-latest
+    permissions:
+      contents: read
+    steps:
+      - uses: actions/checkout@v4
+
+      - uses: oven-sh/setup-bun@v2
+        with:
+          bun-version: 1.3.11
+
+      - name: Install dependencies
+        run: bun install
+
+      - name: Run tests
+        run: bun test

bin/opencode-memory

@@ -177,6 +177,14 @@ AUTODREAM_STALE_LOCK_SECS=$((60 * 60))
 
 WORKING_DIR="${OPENCODE_MEMORY_DIR:-$(pwd)}"
 
+TMP_BASE_DIR="${TMPDIR:-/tmp}"
+while [ "$TMP_BASE_DIR" != "/" ] && [ "${TMP_BASE_DIR%/}" != "$TMP_BASE_DIR" ]; do
+  TMP_BASE_DIR="${TMP_BASE_DIR%/}"
+done
+if [ -z "$TMP_BASE_DIR" ]; then
+  TMP_BASE_DIR="/"
+fi
+
 # Scope lock files at project root granularity (not per-subdirectory).
 PROJECT_SCOPE_DIR="$WORKING_DIR"
 if git -C "$WORKING_DIR" rev-parse --show-toplevel >/dev/null 2>&1; then
@@ -186,7 +194,7 @@ fi
 PROJECT_KEY="$(printf '%s' "$PROJECT_SCOPE_DIR" | cksum | awk '{print $1}')"
 
 # Lock files (prevent concurrent work on the same project)
-LOCK_DIR="${TMPDIR:-/tmp}/opencode-memory-locks"
+LOCK_DIR="$TMP_BASE_DIR/opencode-memory-locks"
 mkdir -p "$LOCK_DIR"
 EXTRACT_LOCK_FILE="$LOCK_DIR/${PROJECT_KEY}.extract.lock"
 
@@ -195,7 +203,7 @@ mkdir -p "$STATE_DIR"
 CONSOLIDATION_LOCK_FILE="$STATE_DIR/${PROJECT_KEY}.consolidate-lock"
 
 # Logs
-LOG_DIR="${TMPDIR:-/tmp}/opencode-memory-logs"
+LOG_DIR="$TMP_BASE_DIR/opencode-memory-logs"
 mkdir -p "$LOG_DIR"
 TASK_LOG_PREFIX="$(date +%Y%m%d-%H%M%S)-${PROJECT_KEY}"
 EXTRACT_LOG_FILE="$LOG_DIR/extract-${TASK_LOG_PREFIX}.log"

test/github-actions-ci.test.ts

@@ -0,0 +1,21 @@
+import { describe, expect, test } from "bun:test"
+import { existsSync, readFileSync } from "fs"
+import { join } from "path"
+
+const workflowPath = join(process.cwd(), ".github", "workflows", "ci.yml")
+
+describe("GitHub Actions CI workflow", () => {
+  test("defines pull request validation that installs dependencies and runs bun test", () => {
+    expect(existsSync(workflowPath)).toBe(true)
+
+    const workflow = readFileSync(workflowPath, "utf-8")
+
+    expect(workflow).toContain("on:")
+    expect(workflow).toContain("pull_request:")
+    expect(workflow).toContain("push:")
+    expect(workflow).toContain("branches: [main]")
+    expect(workflow).toContain("oven-sh/setup-bun")
+    expect(workflow).toContain("bun install")
+    expect(workflow).toContain("bun test")
+  })
+})

test/opencode-memory.test.ts

@@ -0,0 +1,89 @@
+import { afterEach, describe, expect, test } from "bun:test"
+import { chmodSync, existsSync, mkdtempSync, mkdirSync, readFileSync, rmSync, writeFileSync } from "fs"
+import { tmpdir } from "os"
+import { join } from "path"
+import { spawnSync } from "child_process"
+
+const tempRoots: string[] = []
+const scriptPath = join(process.cwd(), "bin", "opencode-memory")
+
+function makeTempRoot(): string {
+  const root = mkdtempSync(join(tmpdir(), "opencode-memory-test-"))
+  tempRoots.push(root)
+  return root
+}
+
+function writeExecutable(filePath: string, content: string): void {
+  writeFileSync(filePath, content, "utf-8")
+  chmodSync(filePath, 0o755)
+}
+
+afterEach(() => {
+  while (tempRoots.length > 0) {
+    const root = tempRoots.pop()
+    if (root) {
+      rmSync(root, { recursive: true, force: true })
+    }
+  }
+})
+
+describe("opencode-memory wrapper", () => {
+  test("normalizes TMPDIR before composing extraction log paths", () => {
+    const root = makeTempRoot()
+    const fakeBin = join(root, "bin")
+    const homeDir = join(root, "home")
+    const tmpDir = `${join(root, "tmp")}/`
+    const claudeDir = join(root, "claude")
+
+    mkdirSync(fakeBin, { recursive: true })
+    mkdirSync(homeDir, { recursive: true })
+    mkdirSync(tmpDir, { recursive: true })
+    mkdirSync(claudeDir, { recursive: true })
+
+    writeExecutable(
+      join(fakeBin, "opencode"),
+      `#!/usr/bin/env bash
+set -euo pipefail
+if [ "\${1:-}" = "session" ] && [ "\${2:-}" = "list" ]; then
+  echo '[{"id":"ses_test_123","time":{"updated":1,"created":1}}]'
+  exit 0
+fi
+if [ "\${1:-}" = "run" ]; then
+  echo "extraction ok"
+  exit 0
+fi
+if [ "\${1:-}" = "--help" ]; then
+  echo "fake help"
+  exit 0
+fi
+exit 0
+`,
+    )
+
+    const result = spawnSync("bash", [scriptPath, "--help"], {
+      cwd: root,
+      encoding: "utf-8",
+      env: {
+        ...process.env,
+        PATH: `${fakeBin}:${process.env.PATH ?? ""}`,
+        HOME: homeDir,
+        TMPDIR: tmpDir,
+        CLAUDE_CONFIG_DIR: claudeDir,
+        OPENCODE_MEMORY_FOREGROUND: "1",
+        OPENCODE_MEMORY_AUTODREAM: "0",
+      },
+    })
+
+    expect(result.status).toBe(0)
+    expect(result.stderr).toContain("Extraction log: ")
+    expect(result.stderr).not.toContain("//opencode-memory-logs")
+
+    const logPathMatch = result.stderr.match(/Extraction log: (.+)\n/)
+    expect(logPathMatch).not.toBeNull()
+
+    const logPath = logPathMatch?.[1].trim() ?? ""
+    expect(logPath.startsWith(join(root, "tmp", "opencode-memory-logs", "extract-"))).toBe(true)
+    expect(existsSync(logPath)).toBe(true)
+    expect(readFileSync(logPath, "utf-8")).toContain("extraction ok")
+  })
+})