fix: Normalize TMPDIR paths in wrapper#6
Merged
Conversation
kuitos
changed the title
|
🎉 This PR is included in version 1.3.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix the wrapper's temporary path handling so macOS-style
TMPDIRvalues that end with/do not produce log and lock paths with doubled separators.Root Cause
The wrapper composed
LOCK_DIRandLOG_DIRwith${TMPDIR:-/tmp}/.... On macOS,TMPDIRusually already ends with/, so the resulting paths were rendered as.../T//opencode-memory-logs/....Changes
opencodebinary with a trailing-slashTMPDIRImpact
Paths are now rendered cleanly in logs and internal lock/log file locations are consistent regardless of whether
TMPDIRends with/.Validation
bun test