Fixed : Edge checks for cMid preventing it from getting index out of bounds.#1623
Open
yrajat01 wants to merge 1 commit intokunal-kushwaha:mainfrom
Open
Fixed : Edge checks for cMid preventing it from getting index out of bounds.#1623yrajat01 wants to merge 1 commit intokunal-kushwaha:mainfrom
yrajat01 wants to merge 1 commit intokunal-kushwaha:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the original program, when searching in the four quadrants, we were looking up with cMid-1 and cMid+1, but if cMid is 0 then cMid-1 is not possible and the program will throw -1 index out of bounds error. Likewise when doing cMid+1, if cMid is already on the last column of the matrix it is not possible to exceed the search and again the program will throw Index Out Of Bounds error.
I have fixed these edge cases. Please do review and accept the pull request.
Thank You for this superb course on DSA with Java.