Skip to content

Fixed : Edge checks for cMid preventing it from getting index out of bounds. #1623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yrajat01 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fixed : Edge checks for cMid preventing it from getting index out of bounds. #1623

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions lectures/10-binary search/code/src/com/kunal/SortedMatrix.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,18 +64,24 @@ static int[] search(int[][] matrix, int target) {
return new int[]{rStart + 1, cMid};
}

// rEnd = rStart+1 (this will cause no error)

/*
Introducing edge checks for cMid so that it does not get out of bounds.
*/
// search in 1st half
if (target <= matrix[rStart][cMid - 1]) {
if (cMid > 0 && target <= matrix[rStart][cMid - 1]) {
return binarySearch(matrix, rStart, 0, cMid-1, target);
}
// search in 2nd half
if (target >= matrix[rStart][cMid + 1] && target <= matrix[rStart][cols - 1]) {
if (cMid < cols - 1 && target >= matrix[rStart][cMid + 1] && target <= matrix[rStart][cols - 1]) {
return binarySearch(matrix, rStart, cMid + 1, cols - 1, target);
}
// search in 3rd half
if (target <= matrix[rStart + 1][cMid - 1]) {
if (cMid > 0 && target <= matrix[rStart + 1][cMid - 1]) {
return binarySearch(matrix, rStart + 1, 0, cMid-1, target);
} else {
}
else {
return binarySearch(matrix, rStart + 1, cMid + 1, cols - 1, target);
}
}
Expand Down