Add function for getting thumbnail batches.#164
Open
rain2o wants to merge 1 commit intokunalvarma05:developfrom
Open
Add function for getting thumbnail batches.#164rain2o wants to merge 1 commit intokunalvarma05:developfrom
rain2o wants to merge 1 commit intokunalvarma05:developfrom
Conversation
|
Hey, thanks for the pull request! It really helped me! When a .zip file is in the list of files, I get the following: PHP Warning: Undefined array key "metadata" in /Dropbox/Models/ThumbnailList.php on line 30 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #152
Added the ability to retrieve thumbnails in batches. In order to accomplish this I had to add the ability to have different Endpoint Types and Endpoint Formats. As per the Dropbox documentation the thumbnail batch endpoint uses the Content endpoint, but it requires the RPC format (which is typically used by the regular API). Including the
Dropbox-API-Argheader throws an error for this endpoint. So I added an additional optional argument forendpointFormat. By default it matches theendpointType, but added a function to make a call to the Content API with the RPC format.I did it this way in an attempt to reduce the amount of impactful changes where possible. Instead of changing
postToContentwhich would require modifying a lot of calls to that function, I created a new function to use this difference -postToContentAsRpc.Let me know if you'd like it done in a different way. This is a feature I require in my current project to be able to use this package. I'm having to use a patch until this gets implemented.