More tweaks

Author: kunitoki

cmake/yup_modules.cmake

@@ -67,7 +67,7 @@ function (_yup_module_collect_sources folder output_variable)
     set (base_path "${folder}/${module_name}")
     set (all_module_sources "")
 
-    foreach (extension ${source_extensions})
+    foreach (extension IN LISTS source_extensions)
         file (GLOB found_source_files "${base_path}*${extension}")
 
         if (NOT YUP_PLATFORM_MSFT)
@@ -118,7 +118,7 @@ function (_yup_module_collect_sources folder output_variable)
     endforeach()
 
     set (module_sources "")
-    foreach (module_source ${all_module_sources})
+    foreach (module_source IN LISTS all_module_sources)
         if (APPLE)
             if (module_source MATCHES "^.*\.(cc|cxx|cpp)$")
                 get_filename_component (source_directory ${module_source} DIRECTORY)
@@ -146,11 +146,11 @@ endfunction()
 
 function (_yup_module_prepare_frameworks frameworks weak_frameworks output_variable)
     set (temp_frameworks "")
-    foreach (framework ${frameworks})
+    foreach (framework IN LISTS frameworks)
         list (APPEND temp_frameworks "-framework ${framework}")
     endforeach()
 
-    foreach (framework ${weak_frameworks})
+    foreach (framework IN LISTS weak_frameworks)
         list (APPEND temp_frameworks "-weak_framework ${framework}")
     endforeach()
 
@@ -345,7 +345,7 @@ function (yup_add_module module_path modules_definitions module_group)
     set (platform_properties "^(.*)Deps$|^(.*)Defines$|^(.*)Libs$|^(.*)Frameworks$|^(.*)WeakFrameworks$|^(.*)Options$|^(.*)LinkOptions$|^(.*)Packages$|^(.*)Searchpaths$|^(.*)CppStandard$")
 
     set (parsed_config "")
-    foreach (module_config ${module_configs})
+    foreach (module_config IN LISTS module_configs)
         string (REGEX REPLACE "^(.+):[ \t\r\n]+(.+)$" "\\1;\\2" parsed_config ${module_config})
         list (GET parsed_config 0 key)
         list (LENGTH parsed_config parsed_config_len)
@@ -452,7 +452,7 @@ function (yup_add_module module_path modules_definitions module_group)
         list (APPEND module_link_options ${module_linuxLinkOptions})
         _yup_resolve_variable_paths ("${module_linuxSearchpaths}" module_linuxSearchpaths)
         list (APPEND module_searchpaths ${module_linuxSearchpaths})
-        foreach (package ${module_linuxPackages})
+        foreach (package IN LISTS module_linuxPackages)
             _yup_get_package_config_libs ("${package}" package_libs)
             list (APPEND module_libs ${package_libs})
         endforeach()
@@ -505,15 +505,15 @@ function (yup_add_module module_path modules_definitions module_group)
     endif()
 
     # ==== Add module definitions
-    foreach (module_definition ${modules_definitions})
+    foreach (module_definition IN LISTS modules_definitions)
         list (APPEND module_defines ${module_definition})
     endforeach()
 
     # ==== Prepare include paths
     get_filename_component (module_include_path ${module_path} DIRECTORY)
     list (APPEND module_include_paths "${module_include_path}")
 
-    foreach (searchpath ${module_searchpaths})
+    foreach (searchpath IN LISTS module_searchpaths)
         if (EXISTS "${searchpath}")
             list (APPEND module_include_paths "${searchpath}")
         elseif (EXISTS "${module_path}/${searchpath}")

tests/yup_dsp/yup_BiquadFilter.cpp

@@ -25,18 +25,15 @@
 
 using namespace yup;
 
-namespace
-{
-constexpr double tolerance = 1e-4;
-constexpr float toleranceF = 1e-4f;
-constexpr double sampleRate = 44100.0;
-constexpr int blockSize = 256;
-} // namespace
-
 //==============================================================================
 class BiquadFilterTests : public ::testing::Test
 {
 protected:
+    static constexpr double tolerance = 1e-4;
+    static constexpr float toleranceF = 1e-4f;
+    static constexpr double sampleRate = 44100.0;
+    static constexpr int blockSize = 256;
+
     void SetUp() override
     {
         filterFloat.prepare (sampleRate, blockSize);

tests/yup_dsp/yup_ButterworthFilter.cpp

@@ -25,18 +25,15 @@
 
 using namespace yup;
 
-namespace
-{
-constexpr double tolerance = 1e-4;
-constexpr float toleranceF = 1e-4f;
-constexpr double sampleRate = 44100.0;
-constexpr int blockSize = 256;
-} // namespace
-
 //==============================================================================
 class ButterworthFilterTests : public ::testing::Test
 {
 protected:
+    static constexpr double tolerance = 1e-4;
+    static constexpr float toleranceF = 1e-4f;
+    static constexpr double sampleRate = 44100.0;
+    static constexpr int blockSize = 256;
+
     void SetUp() override
     {
         filterFloat.prepare (sampleRate, blockSize);

tests/yup_dsp/yup_FilterDesigner.cpp

@@ -25,17 +25,14 @@
 
 using namespace yup;
 
-namespace
-{
-constexpr double tolerance = 1e-4;
-constexpr float toleranceF = 1e-4f;
-constexpr double sampleRate = 44100.0;
-} // namespace
-
 //==============================================================================
 class FilterDesignerTests : public ::testing::Test
 {
 protected:
+    static constexpr double tolerance = 1e-4;
+    static constexpr float toleranceF = 1e-4f;
+    static constexpr double sampleRate = 44100.0;
+
     void SetUp() override
     {
         // Common test parameters
@@ -360,4 +357,4 @@ TEST_F (FilterDesignerTests, FloatPrecisionConsistency)
     EXPECT_NEAR (doubleCoeffs.b2, static_cast<double> (floatCoeffs.b2), toleranceF);
     EXPECT_NEAR (doubleCoeffs.a1, static_cast<double> (floatCoeffs.a1), toleranceF);
     EXPECT_NEAR (doubleCoeffs.a2, static_cast<double> (floatCoeffs.a2), toleranceF);
-}
+}

tests/yup_dsp/yup_FirstOrderFilter.cpp

@@ -25,18 +25,15 @@
 
 using namespace yup;
 
-namespace
-{
-constexpr double tolerance = 1e-4;
-constexpr float toleranceF = 1e-4f;
-constexpr double sampleRate = 44100.0;
-constexpr int blockSize = 256;
-} // namespace
-
 //==============================================================================
 class FirstOrderFilterTests : public ::testing::Test
 {
 protected:
+    static constexpr double tolerance = 1e-4;
+    static constexpr float toleranceF = 1e-4f;
+    static constexpr double sampleRate = 44100.0;
+    static constexpr int blockSize = 256;
+
     void SetUp() override
     {
         filterFloat.prepare (sampleRate, blockSize);

tests/yup_dsp/yup_RbjFilter.cpp

@@ -25,18 +25,15 @@
 
 using namespace yup;
 
-namespace
-{
-constexpr double tolerance = 1e-6;
-constexpr float toleranceF = 1e-5f;
-constexpr double sampleRate = 44100.0;
-constexpr int blockSize = 256;
-} // namespace
-
 //==============================================================================
 class RbjFilterTests : public ::testing::Test
 {
 protected:
+    static constexpr double tolerance = 1e-6;
+    static constexpr float toleranceF = 1e-5f;
+    static constexpr double sampleRate = 44100.0;
+    static constexpr int blockSize = 256;
+
     void SetUp() override
     {
         filterFloat.prepare (sampleRate, blockSize);

tests/yup_dsp/yup_SpectrumAnalyzerState.cpp

@@ -25,15 +25,12 @@
 
 using namespace yup;
 
-namespace
-{
-constexpr float tolerance = 1e-6f;
-} // namespace
-
 //==============================================================================
 class SpectrumAnalyzerStateTests : public ::testing::Test
 {
 protected:
+    static constexpr float tolerance = 1e-6f;
+
     void SetUp() override
     {
         analyzer = std::make_unique<SpectrumAnalyzerState>();

tests/yup_dsp/yup_StateVariableFilter.cpp

@@ -25,18 +25,15 @@
 
 using namespace yup;
 
-namespace
-{
-constexpr double tolerance = 1e-4;
-constexpr float toleranceF = 1e-4f;
-constexpr double sampleRate = 44100.0;
-constexpr int blockSize = 256;
-} // namespace
-
 //==============================================================================
 class StateVariableFilterTests : public ::testing::Test
 {
 protected:
+    static constexpr double tolerance = 1e-4;
+    static constexpr float toleranceF = 1e-4f;
+    static constexpr double sampleRate = 44100.0;
+    static constexpr int blockSize = 256;
+
     void SetUp() override
     {
         filterFloat.prepare (sampleRate, blockSize);

tests/yup_dsp/yup_WindowFunctions.cpp

@@ -25,19 +25,16 @@
 
 using namespace yup;
 
-namespace
-{
-constexpr double tolerance = 1e-4;
-constexpr float toleranceF = 1e-4f;
-constexpr float relaxedToleranceF = 1e-3f;
-constexpr int windowSize = 128;
-constexpr int largeWindowSize = 512;
-} // namespace
-
 //==============================================================================
 class WindowFunctionsTests : public ::testing::Test
 {
 protected:
+    static constexpr double tolerance = 1e-4;
+    static constexpr float toleranceF = 1e-4f;
+    static constexpr float relaxedToleranceF = 1e-3f;
+    static constexpr int windowSize = 128;
+    static constexpr int largeWindowSize = 512;
+
     void SetUp() override
     {
         // Initialize test vectors
@@ -607,4 +604,4 @@ TEST_F (WindowFunctionsTests, TypeAliases)
     EXPECT_TRUE (std::isfinite (value1));
     EXPECT_TRUE (std::isfinite (value2));
     EXPECT_NEAR (value1, static_cast<float> (value2), toleranceF);
-}
+}