Make File constructor explicit

Author: kunitoki

modules/yup_core/native/yup_Files_android.cpp

@@ -251,12 +251,12 @@ File AndroidContentUriResolver::getLocalFileFromContentUri (const URL& url)
         if (type == "image")
             type = "images";
 
-        return getCursorDataColumn (URL ("content://media/external/" + type + "/media"),
-                                    "_id=?",
-                                    StringArray { mediaId });
+        return File (getCursorDataColumn (URL ("content://media/external/" + type + "/media"),
+                                          "_id=?",
+                                          StringArray { mediaId }));
     }
 
-    return getCursorDataColumn (url);
+    return File (getCursorDataColumn (url));
 }
 
 String AndroidContentUriResolver::getFileNameFromContentUri (const URL& url)
@@ -745,7 +745,7 @@ static File getAppDataDir (bool dataDir)
     LocalRef<jobject> applicationInfo (env->CallObjectMethod (getAppContext().get(), AndroidContext.getApplicationInfo));
     LocalRef<jobject> jString (env->GetObjectField (applicationInfo.get(), dataDir ? AndroidApplicationInfo.dataDir : AndroidApplicationInfo.publicSourceDir));
 
-    return { yupString ((jstring) jString.get()) };
+    return File (yupString ((jstring) jString.get()));
 }
 
 File File::getSpecialLocation (const SpecialLocationType type)

modules/yup_core/native/yup_Files_apple.mm

@@ -163,11 +163,11 @@ bool openDocument(const String& fileName, const String& parameters, const Array<
                 StringArray params;
                 params.addTokens(parameters, true);
 
-                NSMutableArray* paramArray = [NSMutableArray array];
+                NSMutableArray* paramArray = [NSMutableArray array];
                 for (int i = 0; i < params.size(); ++i)
                     [paramArray addObject:yupStringToNS(params[i])];
 
-                NSMutableDictionary* envDict = [NSMutableDictionary dictionary];
+                NSMutableDictionary* envDict = [NSMutableDictionary dictionary];
                 if (environment)
                 {
                     for (int i = 0; i < environment->size(); ++i)
@@ -202,7 +202,7 @@ bool openDocument(const String& fileName, const String& parameters, const Array<
 
                 YUP_BEGIN_IGNORE_DEPRECATION_WARNINGS
 
-                NSMutableDictionary* dict = [NSMutableDictionary dictionary];
+                NSMutableDictionary* dict = [NSMutableDictionary dictionary];
 
                 if (params.size())
                 {
@@ -306,14 +306,15 @@ bool openDocument(const String& fileName, const String& parameters, const Array<
             case userDocumentsDirectory:
                 resultPath = MacFileHelpers::getIOSSystemLocation(NSDocumentDirectory);
                 break;
+
             case userDesktopDirectory:
                 resultPath = MacFileHelpers::getIOSSystemLocation(NSDesktopDirectory);
                 break;
 
             case tempDirectory:
             {
                 File tmp(MacFileHelpers::getIOSSystemLocation(NSCachesDirectory));
-                tmp = tmp.getChildFile(yup_getExecutableFile().getFileNameWithoutExtension());
+                tmp = tmp.getChildFile(File(yup_getExecutableFile().getFileNameWithoutExtension()));
                 tmp.createDirectory();
                 return tmp.getFullPathName();
             }
@@ -322,6 +323,7 @@ bool openDocument(const String& fileName, const String& parameters, const Array<
             case userDocumentsDirectory:
                 resultPath = "~/Documents";
                 break;
+
             case userDesktopDirectory:
                 resultPath = "~/Desktop";
                 break;
@@ -336,21 +338,27 @@ bool openDocument(const String& fileName, const String& parameters, const Array<
             case userMusicDirectory:
                 resultPath = "~/Music";
                 break;
+
             case userMoviesDirectory:
                 resultPath = "~/Movies";
                 break;
+
             case userPicturesDirectory:
                 resultPath = "~/Pictures";
                 break;
+
             case userApplicationDataDirectory:
                 resultPath = "~/Library";
                 break;
+
             case commonApplicationDataDirectory:
                 resultPath = "/Library";
                 break;
+
             case commonDocumentsDirectory:
                 resultPath = "/Users/Shared";
                 break;
+
             case globalApplicationsDirectory:
                 resultPath = "/Applications";
                 break;
@@ -481,11 +489,11 @@ bool openDocument(const String& fileName, const String& parameters, const Array<
     {
         YUP_AUTORELEASEPOOL
         {
-            enumerator = [[NSFileManager defaultManager] enumeratorAtPath:yupStringToNS(directory.getFullPathName())];
-        }
-    }
-
-    ~Pimpl() = default;
+            enumerator = [[NSFileManager defaultManager] enumeratorAtPath:yupStringToNS(directory.getFullPathName())];
+        }
+    }
+
+    ~Pimpl() = default;
 
     bool next(String& filenameFound,
               bool* const isDir,

modules/yup_core/native/yup_Files_wasm.cpp

@@ -135,7 +135,7 @@ File File::getSpecialLocation (const SpecialLocationType type)
     }
     */
 
-    return { "/" };
+    return File ("/");
 }
 
 //==============================================================================