Skip to content

[DEV-762] Allow overriding the deadline at the call level while reading events #339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
w1am merged 2 commits into from
Aug 6, 2025
Merged

[DEV-762] Allow overriding the deadline at the call level while reading events #339

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b830e11
Change operation type of reading to regular
w1am Aug 6, 2025
cf6b6fa
Update github actions
w1am Aug 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/main/java/io/kurrent/dbclient/ReadAllOptions.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ public class ReadAllOptions extends OptionsWithPositionAndResolveLinkTosBase<Rea
private long maxCount;

private ReadAllOptions() {
super(OperationKind.Streaming);
this.direction = Direction.Forwards;
this.maxCount = Long.MAX_VALUE;
}
Expand Down
1 change: 0 additions & 1 deletion src/main/java/io/kurrent/dbclient/ReadStreamOptions.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ public class ReadStreamOptions extends OptionsWithStartRevisionAndResolveLinkTos
private long maxCount;

private ReadStreamOptions() {
super(OperationKind.Streaming);
this.direction = Direction.Forwards;
this.maxCount = Long.MAX_VALUE;
}
Expand Down
61 changes: 57 additions & 4 deletions src/test/java/io/kurrent/dbclient/streams/DeadlineTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@

public interface DeadlineTests extends ConnectionAware {
@RetryingTest(10)
default void testDefaultDeadline() throws Throwable {
default void testDefaultDeadline() {
KurrentDBClient client = getDatabase().connectWith(opts ->
opts.defaultDeadline(1)
.maxDiscoverAttempts(3));
Expand All @@ -21,11 +21,11 @@ default void testDefaultDeadline() throws Throwable {
ExecutionException e = Assertions.assertThrows(ExecutionException.class, () -> client.appendToStream("toto", data).get());
StatusRuntimeException status = (StatusRuntimeException) e.getCause();

Assertions.assertEquals(status.getStatus().getCode(), Status.Code.DEADLINE_EXCEEDED);
Assertions.assertEquals(Status.Code.DEADLINE_EXCEEDED, status.getStatus().getCode());
}

@RetryingTest(3)
default void testOptionLevelDeadline() throws Throwable {
default void testOptionLevelDeadline() {
KurrentDBClient client = getDatabase().defaultClient();
UUID id = UUID.randomUUID();

Expand All @@ -34,6 +34,59 @@ default void testOptionLevelDeadline() throws Throwable {
ExecutionException e = Assertions.assertThrows(ExecutionException.class, () -> client.appendToStream("toto", options, data).get());
StatusRuntimeException status = (StatusRuntimeException) e.getCause();

Assertions.assertEquals(status.getStatus().getCode(), Status.Code.DEADLINE_EXCEEDED);
Assertions.assertEquals(Status.Code.DEADLINE_EXCEEDED, status.getStatus().getCode());
}

@RetryingTest(3)
default void testReadStreamWithDefaultDeadline() {
KurrentDBClient client = getDatabase().connectWith(opts ->
opts.defaultDeadline(1)
.maxDiscoverAttempts(3));

ReadStreamOptions options = ReadStreamOptions.get();

ExecutionException e = Assertions.assertThrows(ExecutionException.class, () -> client.readStream("$users", options).get());
StatusRuntimeException status = (StatusRuntimeException) e.getCause();

Assertions.assertEquals(Status.Code.DEADLINE_EXCEEDED, status.getStatus().getCode());
}

@RetryingTest(3)
default void testReadStreamWithLevelDeadline() {
KurrentDBClient client = getDefaultClient();

ExecutionException e = Assertions.assertThrows(
ExecutionException.class,
() -> client.readStream("$users", ReadStreamOptions.get().deadline(1)).get()
);
StatusRuntimeException status = (StatusRuntimeException) e.getCause();

Assertions.assertEquals(Status.Code.DEADLINE_EXCEEDED, status.getStatus().getCode());
}

@RetryingTest(3)
default void testReadAllWithDefaultDeadline() {
KurrentDBClient client = getDatabase().connectWith(opts ->
opts.defaultDeadline(1)
.maxDiscoverAttempts(3));

ReadAllOptions options = ReadAllOptions.get();

ExecutionException e = Assertions.assertThrows(ExecutionException.class, () -> client.readAll(options).get());
StatusRuntimeException status = (StatusRuntimeException) e.getCause();

Assertions.assertEquals(Status.Code.DEADLINE_EXCEEDED, status.getStatus().getCode());
}

@RetryingTest(3)
default void testReadAllWithLevelDeadline() {
KurrentDBClient client = getDefaultClient();

ReadAllOptions options = ReadAllOptions.get().deadline(1);

ExecutionException e = Assertions.assertThrows(ExecutionException.class, () -> client.readAll(options).get());
StatusRuntimeException status = (StatusRuntimeException) e.getCause();

Assertions.assertEquals(Status.Code.DEADLINE_EXCEEDED, status.getStatus().getCode());
}
}
Loading