You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Remove the vendored file and reference the official googleapis proto package
PR Type
Enhancement
Description
Remove vendored Google RPC proto files from repository
Replace local proto imports with official googleapis package
Update proto imports in streams and rpc files
Add blank lines to multiple Java and configuration files
Diagram Walkthrough
flowchart LR
A["Vendored Proto Files<br/>code.proto, status.proto"] -->|Remove| B["Official googleapis<br/>Package"]
C["Local Proto Imports<br/>kurrentdb/protocol/v1"] -->|Replace with| D["google/rpc Imports"]
D --> E["streams.proto<br/>rpc.proto Updated"]
Loading
File Walkthrough
Relevant files
Dependencies
code.proto
Remove vendored Google RPC code proto file
src/main/proto/kurrentdb/protocol/v1/code.proto
Deleted entire vendored Google RPC code enum definition file
File contained 186 lines of gRPC canonical error codes
Objective: To create a detailed and reliable record of critical system actions for security analysis and compliance.
Status: No audit impact: The changes only adjust proto imports and formatting without introducing or modifying any action logic that would require audit logging.
Generic: Robust Error Handling and Edge Case Management
Objective: Ensure comprehensive error handling that provides meaningful context and graceful degradation
Status: Import change only: Switching proto imports to google/rpc does not add or alter any runtime error handling paths in this diff, so robustness cannot be assessed here.
Objective: To prevent the leakage of sensitive system information through error messages while providing sufficient detail for internal debugging.
Status: Error schema refs: The proto import change to google/rpc/code.proto affects error typing only and does not reveal user-facing error content in this diff.
In streams.proto, change the protobuf package name from event_store.client.streams to kurrentdb.protocol.v1.streams to align with the project's directory structure and naming conventions.
[To ensure code accuracy, apply this suggestion manually]
Suggestion importance[1-10]: 6
__
Why: The suggestion correctly identifies an inconsistent protobuf package name that seems to be a copy-paste remnant, and proposes a fix that aligns it with the project's structure, improving code consistency.
The reason will be displayed to describe this comment to others. Learn more.
@w1am 👉 Created pull request targeting release/v1.1: #354
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
PR Type
Enhancement
Description
Remove vendored Google RPC proto files from repository
Replace local proto imports with official googleapis package
Update proto imports in streams and rpc files
Add blank lines to multiple Java and configuration files
Diagram Walkthrough
File Walkthrough
code.proto
Remove vendored Google RPC code proto filesrc/main/proto/kurrentdb/protocol/v1/code.proto
status.proto
Remove vendored Google RPC status proto filesrc/main/proto/kurrentdb/protocol/v1/status.proto
streams.proto
Update status proto import to googleapissrc/main/proto/kurrentdb/protocol/v1/streams.proto
kurrentdb/protocol/v1/status.prototo
google/rpc/status.protorpc.proto
Update code proto import to googleapissrc/main/proto/kurrentdb/protocol/v2/rpc.proto
kurrentdb/protocol/v1/code.prototo
google/rpc/code.protoAbortProjection.java
Add blank line formattingsrc/main/java/io/kurrent/dbclient/AbortProjection.java
README.md
Add blank line formattingREADME.md