Resolve fetch() URL constants in data source scanner#30
Merged
Conversation
The inline-fetch scanner only extracted endpoints from string literals and template literals, so `fetch(LIST_URL, …)` where LIST_URL was a module-level const silently produced no entry. Collect URL/path string constants alongside the existing base-URL table and resolve bare identifier arguments against it before falling back to path matching. Fixes #29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fetch()calls that use a URL constant #29 — the data-source scanner now detectsfetch()calls whose URL argument is a named constant rather than a string literal.const/let/var NAME = '<url-or-path>'declarations into a lookup table and resolves bare identifier first-arguments (e.g.fetch(LIST_URL, { signal })→/api/items?…) before the legacy/api-path fallback runs./api/items?…) and a full-URL constant (http://localhost:4320/api/items/42).Test plan
pnpm vitest run src/server/__tests__/data-source-scanner.test.ts— 9/9 passpnpm vitest run— 223/223 pass