Skip to content

Commit c3db875

Browse files
committed
ipc: ipc4: helper: drop redundant locking in ipc4_search_for_drv()
Drop the IRQ disable/enable in ipc4_search_for_drv(). The driver list is only modified at FW boot and when a new driver is registered at runtime via SOF_IPC4_GLB_LOAD_LIBRARY IPC. ipc4_search_for_drv() is only used when processing IPC messages. As IPC processing is serialized, it is not possible for the driver list to be modified concurrently with a call to ipc4_search_for_drv(). Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
1 parent 901c0ce commit c3db875

1 file changed

Lines changed: 0 additions & 4 deletions

File tree

src/ipc/ipc4/helper.c

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1142,12 +1142,9 @@ __cold static const struct comp_driver *ipc4_search_for_drv(const void *uuid)
11421142
struct list_item *clist;
11431143
const struct comp_driver *drv = NULL;
11441144
struct comp_driver_info *info;
1145-
uint32_t flags;
11461145

11471146
assert_can_be_cold();
11481147

1149-
irq_local_disable(flags);
1150-
11511148
/* search driver list with UUID */
11521149
list_for_item(clist, &drivers->list) {
11531150
info = container_of(clist, struct comp_driver_info,
@@ -1162,7 +1159,6 @@ __cold static const struct comp_driver *ipc4_search_for_drv(const void *uuid)
11621159
}
11631160
}
11641161

1165-
irq_local_enable(flags);
11661162
return drv;
11671163
}
11681164

0 commit comments

Comments
 (0)