[Store] Implement dual rdma forward path#2092
Open
Shichang-Zhang wants to merge 14 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request implements a forward RDMA data plane path for the Mooncake store, complementing the existing reverse path. Key changes include the introduction of a three-phase control plane (PreWrite/Pin, Transfer, and Commit/UnPin) and a lease-based resource management system within the DataManager to handle pending writes and pinned keys. Client interfaces and Python bindings have been extended to allow users to specify the RDMA direction mode. Feedback identifies a significant limitation where the forward RDMA path currently requires contiguous buffers, recommending improved documentation, more descriptive error codes, and future support for non-contiguous transfers.
3978a85 to
0871e70
Compare
116cc61 to
92f0829
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR implements the forward transfer control path and RPC surface for Mooncake Store.
When forward mode is enabled, writes use PreWrite → RDMA write → WriteCommit and reads use PinKey → RDMA read → UnPinKey. The default reverse path (WriteRemoteData / ReadRemoteData) is unchanged unless callers explicitly select forward.
Use ReadConfigExt/WriteConfigExt (original ReadRouteConifg/WriteRouteConfig) to configure the transfer path direction。
Module
mooncake-transfer-engine)mooncake-store)mooncake-ep)mooncake-integration)mooncake-p2p-store)mooncake-wheel)mooncake-pg)mooncake-rl)Type of Change
How Has This Been Tested?
Checklist
./scripts/code_format.shbefore submitting.