[CI/Build] Fix compile warnings#2825
Merged
Merged
Conversation
Aionw
marked this pull request as ready for review
July 9, 2026 12:46
Aionw
requested review from
XucSh,
YiXR,
alogfans,
chestnut-Q,
doujiang24,
stmatengss and
ykwd
as code owners
July 9, 2026 12:46
Contributor
|
Warning Gemini encountered an error creating the review. You can try again by commenting |
|
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
Lin-z-w
approved these changes
Jul 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix compile warnings in Mooncake-owned C++ code without changing compiler flags.
This addresses:
[[maybe_unused]]where they are intentionally retained for metrics/debug context.MasterServicemember initialization order warnings by matching declaration order.mmap_arena_testby using an explicit assignment.Checked existing open PRs/issues for related compile-warning work. The only open PR found by the search was #2540, which is about MUSA EP builds and does not overlap this change.
Module
mooncake-transfer-engine)mooncake-store)mooncake-ep)mooncake-pg)mooncake-integration)mooncake-p2p-store)mooncake-wheel)mooncake-common)mooncake-rl)Type of Change
How Has This Been Tested?
Test commands:
cmake -S . -B build-codex -G Ninja -DWITH_STORE_RUST=OFF cmake --build build-codex -j8 git diff --check pre-commit run --files mooncake-store/src/file_storage.cpp mooncake-store/src/master_metric_manager.cpp mooncake-store/src/master_service.cpp mooncake-store/src/real_client.cpp mooncake-store/tests/mmap_arena_test.cpp mooncake-transfer-engine/include/transport/rpc_communicator/rpc_communicator.h mooncake-transfer-engine/src/transport/rpc_communicator/rpc_communicator.cpp mooncake-transfer-engine/src/transport/rpc_communicator/rpc_interface.cppTest results:
Build completed successfully. The only remaining warning observed during configuration was from
extern/pybind11, which is dependency code.pre-commit run --filespassed the standard hooks, but the project format hook scans a wider diff againstorigin/mainand repeatedly rewrote an unrelated file (mooncake-store/include/kv_event/kv_event_config.h). That unrelated formatting change was restored and not included in this PR.Checklist
./scripts/code_format.shpre-commit run --all-filesand all hooks passNo documentation or new tests are needed; this change only removes compile warnings from existing code paths.
AI Assistance Disclosure
Codex was used to identify warning sources, apply the source changes, run build/pre-commit validation, and prepare this PR.