[build]: pin accelerate-kt torch 2.9.1 dependency#1
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the torch dependency in setup.py from a version range to a specific version (2.9.1). Feedback suggests using a more flexible version range instead of an exact pin to avoid potential dependency conflicts for downstream users while maintaining compatibility.
| "psutil", | ||
| "pyyaml", | ||
| "torch>=2.10,<2.12", | ||
| "torch==2.9.1", |
There was a problem hiding this comment.
Pinning a dependency to an exact version (==2.9.1) in setup.py is generally discouraged for libraries as it can lead to version conflicts for downstream users. If the intent is to avoid versions 2.10 and 2.11 while ensuring compatibility with the 2.9.x series, consider using a version range like torch>=2.9.1,<2.10.0. This provides more flexibility for patch updates and environment resolution while still achieving the goal of excluding the problematic versions.
| "torch==2.9.1", | |
| "torch>=2.9.1,<2.10.0", |
Pin accelerate-kt metadata to torch==2.9.1 so the KT SFT stack does not resolve torch 2.10/2.11 by default.