Skip to content

[build]: pin accelerate-kt torch 2.9.1 dependency#1

Merged
JimmyPeilinLi merged 1 commit into
sft-v5from
release/torch291-v061-20260429
Apr 29, 2026
Merged

[build]: pin accelerate-kt torch 2.9.1 dependency#1
JimmyPeilinLi merged 1 commit into
sft-v5from
release/torch291-v061-20260429

Conversation

@JimmyPeilinLi
Copy link
Copy Markdown

Pin accelerate-kt metadata to torch==2.9.1 so the KT SFT stack does not resolve torch 2.10/2.11 by default.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the torch dependency in setup.py from a version range to a specific version (2.9.1). Feedback suggests using a more flexible version range instead of an exact pin to avoid potential dependency conflicts for downstream users while maintaining compatibility.

Comment thread setup.py
"psutil",
"pyyaml",
"torch>=2.10,<2.12",
"torch==2.9.1",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Pinning a dependency to an exact version (==2.9.1) in setup.py is generally discouraged for libraries as it can lead to version conflicts for downstream users. If the intent is to avoid versions 2.10 and 2.11 while ensuring compatibility with the 2.9.x series, consider using a version range like torch>=2.9.1,<2.10.0. This provides more flexibility for patch updates and environment resolution while still achieving the goal of excluding the problematic versions.

Suggested change
"torch==2.9.1",
"torch>=2.9.1,<2.10.0",

@JimmyPeilinLi JimmyPeilinLi merged commit 0988917 into sft-v5 Apr 29, 2026
4 of 26 checks passed
@JimmyPeilinLi JimmyPeilinLi deleted the release/torch291-v061-20260429 branch April 29, 2026 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant