fix(ci): green the build — pre-existing biome lint + astro readonly-array errors

These failed CI (Lint + Type Check (Astro) steps) on main independent of the
auth/deploy work — surfaced while monitoring CI for the patchDeploy fix:

- functions/kychon-api.js: noUselessTernary (input.published === false ? false : true
  -> input.published !== false; behavior-equivalent).
- tests/unit/i18n.test.js: move the noDocumentCookie biome-ignore directive to sit
  directly above the document.cookie write (it was 3 comment lines off, so the
  suppression was unused AND the violation unsuppressed).
- src/lib/build-events.ts + build-announcements.ts: getAllBuildEvents /
  getAllBuildAnnouncements returned readonly arrays not assignable to the mutable
  BlockRenderContext.buildEvents/buildAnnouncements + EventsPageApp props — return a
  shallow copy so the type matches and the shared cache stays protected.
- biome format + organizeImports auto-fixes on 3 test files.

Verified: biome check ., astro check (0 errors), tsc --project tsconfig.scripts.json,
vitest 1050/1050 — all green.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Author: MajorTal

functions/kychon-api.js

@@ -1452,7 +1452,7 @@ async function createPageWithNav(input, _actor) {
     requires_auth: requiresAuth,
     show_in_nav: showInNav,
     nav_position: navPosition,
-    published: input.published === false ? false : true,
+    published: input.published !== false,
   });
 
   const changed = [changedObject('page', page.id ?? slug)];

src/lib/build-announcements.ts

@@ -109,10 +109,12 @@ export async function ensureBuildAnnouncementsLoaded(): Promise<void> {
  * Return the unfiltered build-time announcements cache. Used by
  * `.astro` frontmatter to stamp `ctx.buildAnnouncements` once per
  * page render; `blocks.ts:ANNOUNCEMENTS_FEED.render` slices it
- * (`limit` from the block's config) synchronously.
+ * (`limit` from the block's config) synchronously. Returns a shallow copy so
+ * callers (mutable `BlockRenderContext.buildAnnouncements`) can't mutate the
+ * shared cache.
  */
-export function getAllBuildAnnouncements(): readonly Announcement[] | null {
-  return cache;
+export function getAllBuildAnnouncements(): Announcement[] | null {
+  return cache ? cache.slice() : null;
 }
 
 /** Test-only: clear the cache between test runs. */

src/lib/build-events.ts

@@ -163,10 +163,12 @@ export function getBuildEvents(filter: BuildEventsFilter, count: number): Event[
  * stamp `ctx.buildEvents` once per page render so each `events_list`
  * block can apply its own filter+count synchronously. Prefer
  * `getBuildEvents(filter, count)` when you want a single block's
- * sliced view — this is the raw cache.
+ * sliced view. Returns a shallow copy so callers (mutable
+ * `BlockRenderContext.buildEvents`, `EventsPageApp` props) can't mutate the
+ * shared cache.
  */
-export function getAllBuildEvents(): readonly Event[] | null {
-  return cache;
+export function getAllBuildEvents(): Event[] | null {
+  return cache ? cache.slice() : null;
 }
 
 /** Test-only: clear the cache between test runs. */

tests/unit/capability-api-query-handlers.test.ts

@@ -222,9 +222,9 @@ describe('Capability API query handlers', () => {
 
   it('gates members.list / members.get on site_config.directory_public for anonymous actors', async () => {
     // Without directory_public set, anonymous is denied.
-    await expect(
-      runCapabilityQuery('members.list', {}, { actor: anonymousActor, db: sampleDb() }),
-    ).rejects.toThrow(/permission denied for members.list/i);
+    await expect(runCapabilityQuery('members.list', {}, { actor: anonymousActor, db: sampleDb() })).rejects.toThrow(
+      /permission denied for members.list/i,
+    );
 
     // With directory_public=true, anonymous can list — sensitive
     // fields (email, custom_fields) stay redacted by memberRow.
@@ -263,7 +263,7 @@ describe('Capability API query handlers', () => {
       {},
       { actor: memberActor, db: sampleDb() },
     )) as JsonObject;
-    expect((memberListPrivate.rows as JsonObject[])).toHaveLength(1);
+    expect(memberListPrivate.rows as JsonObject[]).toHaveLength(1);
   });
 
   it('implements events, registration options, RSVPs, announcements, and resources', async () => {

tests/unit/i18n.test.js

@@ -33,10 +33,10 @@ describe('i18n.js', () => {
     vi.resetModules();
     mockFetch.mockReset();
     localStorage._data = {};
-    // biome-ignore lint/suspicious/noDocumentCookie: this is a mocked document
-    // for unit tests, not a real browser context — the Cookie Store API isn't
-    // available here. Production cookie write at src/lib/i18n.ts:setLanguage
-    // is in biome's ignore list.
+    // Mocked document for unit tests, not a real browser context — the Cookie
+    // Store API isn't available here. Production cookie write at
+    // src/lib/i18n.ts:setLanguage is in biome's ignore list.
+    // biome-ignore lint/suspicious/noDocumentCookie: mocked document for unit tests
     document.cookie = '';
 
     // Default mock: brand.json returns en

tests/unit/kychon-image-blurhash-data-url.test.ts

@@ -15,15 +15,15 @@
  * These tests assert that behavior at the `kychonImageHtml` boundary
  * (`lqipDataUri` is internal to the module and not exported separately).
  */
-import { describe, expect, it } from 'vitest';
+
 import type { AssetRef } from '@run402/astro';
+import { describe, expect, it } from 'vitest';
 import { kychonImageHtml } from '../../src/lib/kychon-image';
 
 // A well-formed PNG data URL that's deliberately distinct from anything
 // the blurhash decoder would actually produce — lets the assertion confirm
 // the value came from the AssetRef field, not from a decode.
-const SENTINEL_DATA_URL =
-  'data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAACAAAAAgCAYAAABzenr0AAAAQElEQVRFAEQOPYHa0eTL';
+const SENTINEL_DATA_URL = 'data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAACAAAAAgCAYAAABzenr0AAAAQElEQVRFAEQOPYHa0eTL';
 
 // A real-shape blurhash string the decoder can process. Used to exercise
 // the fallback path; the test asserts on the data-URL prefix, not the
@@ -79,8 +79,7 @@ describe('kychon-image v1.54 blurhash_data_url fast path', () => {
     // `blurhash_data_url` is a v1.54 field not yet in @run402/astro@0.2.5's
     // AssetRef type; cast locally to attach it. `blurhash` is also set to
     // prove the fast path WINS over the fallback when both are available.
-    (ref as AssetRef & { blurhash_data_url?: string | null }).blurhash_data_url =
-      SENTINEL_DATA_URL;
+    (ref as AssetRef & { blurhash_data_url?: string | null }).blurhash_data_url = SENTINEL_DATA_URL;
     ref.blurhash = SAMPLE_BLURHASH;
 
     const html = kychonImageHtml(ref, 'hero', { sizes: '100vw' });

tests/unit/main-zone-signature.test.ts

@@ -65,7 +65,10 @@ describe('computeMainZoneSignature', () => {
     const b = baseSection({ id: 'sec-2', position: 1, section_type: 'promo_cards' });
     const sig1 = computeMainZoneSignature({ sections: [a, b], manifestGeneratedAt: null });
     const sig2 = computeMainZoneSignature({
-      sections: [{ ...a, position: 1 }, { ...b, position: 0 }],
+      sections: [
+        { ...a, position: 1 },
+        { ...b, position: 0 },
+      ],
       manifestGeneratedAt: null,
     });
     expect(sig1).not.toBe(sig2);