merge: fix test failures + CI glob gap

Author: volinskey

.github/workflows/test.yml

@@ -20,6 +20,13 @@ jobs:
       - run: npm run build
       - run: npm run test:skill
       - run: npm run test:sync
-      - run: node --experimental-test-module-mocks --test --import tsx src/**/*.test.ts
+      # Use bash globstar so `**` recurses into nested dirs AND matches files
+      # at depth 0. Without this, files like src/keystore.test.ts (at depth 0)
+      # were silently skipped by CI for 20+ days. Also explicitly run the
+      # core/src tests, which were never matched by the old glob.
+      - shell: bash
+        run: |
+          shopt -s globstar
+          node --experimental-test-module-mocks --test --import tsx src/**/*.test.ts core/src/**/*.test.ts
       - run: npm run test:e2e
       - run: npm run test:integration

core/src/allowance.test.ts

@@ -35,7 +35,7 @@ describe("allowance", () => {
     assert.deepEqual(loaded, allowance);
   });
 
-  it("creates file with 0600 permissions", () => {
+  it("creates file with 0600 permissions", { skip: process.platform === "win32" ? "POSIX file modes not enforced on Windows NTFS" : false }, () => {
     saveAllowance({ address: "0x1", privateKey: "0x2" }, allowancePath);
     const stats = statSync(allowancePath);
     const mode = stats.mode & 0o777;

core/src/config.test.ts

@@ -42,13 +42,15 @@ describe("config", () => {
 
   it("derives keystore path from config dir", () => {
     process.env.RUN402_CONFIG_DIR = "/tmp/test-config";
-    assert.equal(getKeystorePath(), "/tmp/test-config/projects.json");
+    // Use path.join in the expected value so the test passes on both POSIX
+    // and Windows (Windows produces backslashes via path.join).
+    assert.equal(getKeystorePath(), join("/tmp/test-config", "projects.json"));
   });
 
   it("derives allowance path from config dir", () => {
     process.env.RUN402_CONFIG_DIR = "/tmp/test-config";
     delete process.env.RUN402_ALLOWANCE_PATH;
-    assert.equal(getAllowancePath(), "/tmp/test-config/allowance.json");
+    assert.equal(getAllowancePath(), join("/tmp/test-config", "allowance.json"));
   });
 
   it("returns custom allowance path from RUN402_ALLOWANCE_PATH env", () => {

core/src/keystore.test.ts

@@ -34,7 +34,7 @@ describe("core keystore", () => {
     assert.deepEqual(loaded, project);
   });
 
-  it("creates file with 0600 permissions", () => {
+  it("creates file with 0600 permissions", { skip: process.platform === "win32" ? "POSIX file modes not enforced on Windows NTFS" : false }, () => {
     saveProject("proj-002", {
       anon_key: "ak", service_key: "sk",
     }, storePath);

src/keystore.test.ts

@@ -28,21 +28,17 @@ describe("keystore", () => {
     const project: StoredProject = {
       anon_key: "anon-key-123",
       service_key: "svc-key-456",
-      tier: "prototype",
-      lease_expires_at: "2026-03-06T00:00:00Z",
     };
     saveProject("proj-001", project, storePath);
 
     const loaded = getProject("proj-001", storePath);
     assert.deepEqual(loaded, project);
   });
 
-  it("creates file with 0600 permissions", () => {
+  it("creates file with 0600 permissions", { skip: process.platform === "win32" ? "POSIX file modes not enforced on Windows NTFS" : false }, () => {
     const project: StoredProject = {
       anon_key: "ak",
       service_key: "sk",
-      tier: "hobby",
-      lease_expires_at: "2026-04-01T00:00:00Z",
     };
     saveProject("proj-002", project, storePath);
 
@@ -55,14 +51,10 @@ describe("keystore", () => {
     const p1: StoredProject = {
       anon_key: "ak1",
       service_key: "sk1",
-      tier: "prototype",
-      lease_expires_at: "2026-03-01T00:00:00Z",
     };
     const p2: StoredProject = {
       anon_key: "ak2",
       service_key: "sk2",
-      tier: "team",
-      lease_expires_at: "2026-04-01T00:00:00Z",
     };
 
     saveProject("proj-a", p1, storePath);
@@ -80,14 +72,10 @@ describe("keystore", () => {
     const v1: StoredProject = {
       anon_key: "old",
       service_key: "old",
-      tier: "prototype",
-      lease_expires_at: "2026-03-01T00:00:00Z",
     };
     const v2: StoredProject = {
       anon_key: "new",
       service_key: "new",
-      tier: "hobby",
-      lease_expires_at: "2026-04-01T00:00:00Z",
     };
 
     saveProject("proj-x", v1, storePath);
@@ -112,8 +100,6 @@ describe("keystore", () => {
     const project: StoredProject = {
       anon_key: "ak",
       service_key: "sk",
-      tier: "prototype",
-      lease_expires_at: "2026-03-01T00:00:00Z",
     };
     saveProject("proj-atomic", project, storePath);