Skip to content

Commit 43d14e4

Browse files
fix: fixed vertical alignment in Firefix browsers (#135)
* fix: use dominant-baseline instead of alignment-baseline for SVG text Co-authored-by: Cursor <cursoragent@cursor.com> * fix: sync venom.svg with actual one --------- Co-authored-by: Cursor <cursoragent@cursor.com>
1 parent 5784863 commit 43d14e4

13 files changed

Lines changed: 67 additions & 79 deletions

File tree

β€Ž__test__/__snapshots__/model.test.ts.snapβ€Ž

Lines changed: 26 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -184,8 +184,8 @@ exports[`Test Models blur model 1`] = `
184184
185185
186186
<text
187-
alignment-baseline="middle"
188187
class="text"
188+
dominant-baseline="middle"
189189
stroke="#none"
190190
stroke-width="1"
191191
style="fill:#f7f5f5;"
@@ -198,8 +198,8 @@ exports[`Test Models blur model 1`] = `
198198
199199
200200
<text
201-
alignment-baseline="middle"
202201
class="desc"
202+
dominant-baseline="middle"
203203
style="fill:#f7f5f5;"
204204
text-anchor="middle"
205205
x="40%"
@@ -276,8 +276,8 @@ exports[`Test Models cylinder model 1`] = `
276276
277277
278278
<text
279-
alignment-baseline="middle"
280279
class="text"
280+
dominant-baseline="middle"
281281
stroke="#none"
282282
stroke-width="1"
283283
style="fill:#f7f5f5;"
@@ -290,8 +290,8 @@ exports[`Test Models cylinder model 1`] = `
290290
291291
292292
<text
293-
alignment-baseline="middle"
294293
class="desc"
294+
dominant-baseline="middle"
295295
style="fill:#f7f5f5;"
296296
text-anchor="middle"
297297
x="40%"
@@ -368,8 +368,8 @@ exports[`Test Models egg model 1`] = `
368368
369369
370370
<text
371-
alignment-baseline="middle"
372371
class="text"
372+
dominant-baseline="middle"
373373
stroke="#none"
374374
stroke-width="1"
375375
style="fill:#f7f5f5;"
@@ -382,8 +382,8 @@ exports[`Test Models egg model 1`] = `
382382
383383
384384
<text
385-
alignment-baseline="middle"
386385
class="desc"
386+
dominant-baseline="middle"
387387
style="fill:#f7f5f5;"
388388
text-anchor="middle"
389389
x="40%"
@@ -460,8 +460,8 @@ exports[`Test Models rect model 1`] = `
460460
461461
462462
<text
463-
alignment-baseline="middle"
464463
class="text"
464+
dominant-baseline="middle"
465465
stroke="#none"
466466
stroke-width="1"
467467
style="fill:#f7f5f5;"
@@ -474,8 +474,8 @@ exports[`Test Models rect model 1`] = `
474474
475475
476476
<text
477-
alignment-baseline="middle"
478477
class="desc"
478+
dominant-baseline="middle"
479479
style="fill:#f7f5f5;"
480480
text-anchor="middle"
481481
x="40%"
@@ -552,8 +552,8 @@ exports[`Test Models rounded model 1`] = `
552552
553553
554554
<text
555-
alignment-baseline="middle"
556555
class="text"
556+
dominant-baseline="middle"
557557
stroke="#none"
558558
stroke-width="1"
559559
style="fill:#f7f5f5;"
@@ -566,8 +566,8 @@ exports[`Test Models rounded model 1`] = `
566566
567567
568568
<text
569-
alignment-baseline="middle"
570569
class="desc"
570+
dominant-baseline="middle"
571571
style="fill:#f7f5f5;"
572572
text-anchor="middle"
573573
x="40%"
@@ -644,8 +644,8 @@ exports[`Test Models shark model 1`] = `
644644
645645
646646
<text
647-
alignment-baseline="middle"
648647
class="text"
648+
dominant-baseline="middle"
649649
stroke="#none"
650650
stroke-width="1"
651651
style="fill:#f7f5f5;"
@@ -658,8 +658,8 @@ exports[`Test Models shark model 1`] = `
658658
659659
660660
<text
661-
alignment-baseline="middle"
662661
class="desc"
662+
dominant-baseline="middle"
663663
style="fill:#f7f5f5;"
664664
text-anchor="middle"
665665
x="40%"
@@ -736,8 +736,8 @@ exports[`Test Models slice model 1`] = `
736736
737737
738738
<text
739-
alignment-baseline="middle"
740739
class="text"
740+
dominant-baseline="middle"
741741
stroke="#none"
742742
stroke-width="1"
743743
style="fill:#f7f5f5;"
@@ -750,8 +750,8 @@ exports[`Test Models slice model 1`] = `
750750
751751
752752
<text
753-
alignment-baseline="middle"
754753
class="desc"
754+
dominant-baseline="middle"
755755
style="fill:#f7f5f5;"
756756
text-anchor="middle"
757757
x="40%"
@@ -831,8 +831,8 @@ exports[`Test Models soft model 1`] = `
831831
832832
833833
<text
834-
alignment-baseline="middle"
835834
class="text"
835+
dominant-baseline="middle"
836836
stroke="#none"
837837
stroke-width="1"
838838
style="fill:#f7f5f5;"
@@ -845,8 +845,8 @@ exports[`Test Models soft model 1`] = `
845845
846846
847847
<text
848-
alignment-baseline="middle"
849848
class="desc"
849+
dominant-baseline="middle"
850850
style="fill:#f7f5f5;"
851851
text-anchor="middle"
852852
x="40%"
@@ -923,8 +923,8 @@ exports[`Test Models speech model 1`] = `
923923
924924
925925
<text
926-
alignment-baseline="middle"
927926
class="text"
927+
dominant-baseline="middle"
928928
stroke="#none"
929929
stroke-width="1"
930930
style="fill:#f7f5f5;"
@@ -937,8 +937,8 @@ exports[`Test Models speech model 1`] = `
937937
938938
939939
<text
940-
alignment-baseline="middle"
941940
class="desc"
941+
dominant-baseline="middle"
942942
style="fill:#f7f5f5;"
943943
text-anchor="middle"
944944
x="40%"
@@ -1034,8 +1034,8 @@ exports[`Test Models transparent model 1`] = `
10341034
10351035
10361036
<text
1037-
alignment-baseline="middle"
10381037
class="text"
1038+
dominant-baseline="middle"
10391039
stroke="#none"
10401040
stroke-width="1"
10411041
style="fill:#f7f5f5;"
@@ -1048,8 +1048,8 @@ exports[`Test Models transparent model 1`] = `
10481048
10491049
10501050
<text
1051-
alignment-baseline="middle"
10521051
class="desc"
1052+
dominant-baseline="middle"
10531053
style="fill:#f7f5f5;"
10541054
text-anchor="middle"
10551055
x="40%"
@@ -1141,8 +1141,8 @@ exports[`Test Models venom model 1`] = `
11411141
11421142
11431143
<text
1144-
alignment-baseline="middle"
11451144
class="text"
1145+
dominant-baseline="middle"
11461146
stroke="#none"
11471147
stroke-width="1"
11481148
style="fill:#f7f5f5;"
@@ -1155,8 +1155,8 @@ exports[`Test Models venom model 1`] = `
11551155
11561156
11571157
<text
1158-
alignment-baseline="middle"
11591158
class="desc"
1159+
dominant-baseline="middle"
11601160
style="fill:#f7f5f5;"
11611161
text-anchor="middle"
11621162
x="40%"
@@ -1233,8 +1233,8 @@ exports[`Test Models wave model 1`] = `
12331233
12341234
12351235
<text
1236-
alignment-baseline="middle"
12371236
class="text"
1237+
dominant-baseline="middle"
12381238
stroke="#none"
12391239
stroke-width="1"
12401240
style="fill:#f7f5f5;"
@@ -1247,8 +1247,8 @@ exports[`Test Models wave model 1`] = `
12471247
12481248
12491249
<text
1250-
alignment-baseline="middle"
12511250
class="desc"
1251+
dominant-baseline="middle"
12521252
style="fill:#f7f5f5;"
12531253
text-anchor="middle"
12541254
x="40%"
@@ -1372,8 +1372,8 @@ exports[`Test Models waving model 1`] = `
13721372
13731373
13741374
<text
1375-
alignment-baseline="middle"
13761375
class="text"
1376+
dominant-baseline="middle"
13771377
stroke="#none"
13781378
stroke-width="1"
13791379
style="fill:#f7f5f5;"
@@ -1386,8 +1386,8 @@ exports[`Test Models waving model 1`] = `
13861386
13871387
13881388
<text
1389-
alignment-baseline="middle"
13901389
class="desc"
1390+
dominant-baseline="middle"
13911391
style="fill:#f7f5f5;"
13921392
text-anchor="middle"
13931393
x="40%"

β€Ždocs/samples/blur.svgβ€Ž

Lines changed: 1 addition & 1 deletion
Loading

β€Ždocs/samples/cylinder.svgβ€Ž

Lines changed: 2 additions & 2 deletions
Loading

β€Ždocs/samples/rect.svgβ€Ž

Lines changed: 2 additions & 2 deletions
Loading

β€Ždocs/samples/rounded.svgβ€Ž

Lines changed: 1 addition & 1 deletion
Loading

β€Ždocs/samples/slice.svgβ€Ž

Lines changed: 2 additions & 2 deletions
Loading

β€Ždocs/samples/soft.svgβ€Ž

Lines changed: 1 addition & 1 deletion
Loading

β€Ždocs/samples/speech.svgβ€Ž

Lines changed: 1 addition & 1 deletion
Loading

β€Ždocs/samples/transparent.svgβ€Ž

Lines changed: 2 additions & 2 deletions
Loading

β€Ždocs/samples/venom.svgβ€Ž

Lines changed: 18 additions & 30 deletions
Loading

0 commit comments

Comments
Β (0)