Skip to content

Commit fb8b09b

Browse files
committed
fix: address PR review - fix README URLs, scope EC2 role ARN to account
- README Quick Start now references opensearch-project/observability-stack main - EC2 demo role uses cfg.accountId instead of wildcard in OSIS ARN Signed-off-by: Kyle Hounslow <kylhouns@amazon.com>
1 parent 9ed062a commit fb8b09b

2 files changed

Lines changed: 3 additions & 4 deletions

File tree

aws/cli-installer/README.md

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,9 +5,8 @@ Deploy the [Observability Stack](https://github.com/opensearch-project/observabi
55
## Quick Start
66

77
```bash
8-
git clone git@github.com:kylehounslow/observability-stack.git
9-
cd observability-stack && git checkout feat/aws-cli-installer
10-
cd aws/cli-installer && npm install
8+
git clone https://github.com/opensearch-project/observability-stack.git
9+
cd observability-stack/aws/cli-installer && npm install
1110

1211
node bin/cli-installer.mjs --managed \
1312
--pipeline-name obs-stack-<your-alias> \

aws/cli-installer/src/ec2-demo.mjs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -198,7 +198,7 @@ async function createDemoInstanceProfile(iam, cfg) {
198198

199199
const ingestPolicy = JSON.stringify({
200200
Version: '2012-10-17',
201-
Statement: [{ Effect: 'Allow', Action: 'osis:Ingest', Resource: `arn:aws:osis:${cfg.region}:*:pipeline/${cfg.pipelineName}` }],
201+
Statement: [{ Effect: 'Allow', Action: 'osis:Ingest', Resource: `arn:aws:osis:${cfg.region}:${cfg.accountId}:pipeline/${cfg.pipelineName}` }],
202202
});
203203

204204
try {

0 commit comments

Comments
 (0)