feat: enforce singleton Gpu CR#58
Conversation
SummaryThe following content is AI-generated and provides a summary of the pull request: Enforce Singleton GPU CRNew Feature✨ Enforces that only a single Changes
Jira IssuesGitHub Issues:
PR Bot InformationVersion:
|
There was a problem hiding this comment.
The PR is well-structured and achieves its goal cleanly. The one substantive issue posted is that a rogue CR with a finalizer (added manually or through a future code change) could trigger reconcileDelete and invoke Installer.Uninstall, potentially uninstalling the legitimate GPU Operator — the singleton guard needs to be moved above (or merged with) the deletion-timestamp check to fully protect the deletion path.
PR Bot Information
Version: 1.20.51
- Correlation ID:
00681b13-103c-4d43-9e40-d84d88791988 - Agent Instructions:
- LLM:
anthropic--claude-4.6-sonnet - Event Trigger:
pull_request.opened - File Content Strategy: Full file content
Description
Changes proposed in this pull request:
Related issue(s)
Make gpu cr singleton