feat: log agent exporter batcher#3548
Conversation
Control PanelHi, I'm an AI-powered Review Bot that helps you with summarizing and reviewing pull requests.
|
SummaryThe following content is AI-generated and provides a summary of the pull request: What ChangedEnables the OTel Collector exporter batcher ( Affected Signal TypesLogs Key Changes
Notes for ReviewersThe bytes-based batcher constants (200 MB queue, 2–4 MB batch, 10 s flush) come from ADR-029 and the associated PoC. The issue notes that the exporter batcher may expose new metrics; those need to be reviewed for integration into self-monitor alerts and OPS dashboards before this is considered fully complete. E2E tests are not yet in place. Release Notes InputRecommended Action: Review whether the new exporter batcher metrics (exposed by the OTel Collector Logs: The log agent OTLP exporter now uses the
PR Bot InformationVersion:
|
There was a problem hiding this comment.
The PR is well-structured overall — the refactoring from a raw queueSize int to a SendingQueue value type with functional options is a clean improvement, and the log agent batching configuration follows the PoC findings. Two issues were flagged: a typo in a comment, and a potential time.Duration YAML serialization bug where the FlushTimeout field may marshal as nanoseconds instead of the "10s" string the golden file and OTel Collector expect — this should be verified and likely changed to string to match the pattern used by RetryOnFailure.
PR Bot Information
Version: 1.20.51
- Agent Instructions:
- Correlation ID:
a0e9acbc-c04c-4b1e-acdb-18377f85e7ce - File Content Strategy: Full file content
- Event Trigger:
issue_comment.edited - LLM:
anthropic--claude-4.6-sonnet - Review Focus Files:
Co-authored-by: hyperspace-insights[bot] <209611008+hyperspace-insights[bot]@users.noreply.github.com>
Description
Changes proposed in this pull request (what was done and why):
Changes refer to particular issues, PRs or documents:
Traceability
Related Issuessection.