Added support for OpenFlow 1.3 OFP_ERROR codes with the get_class method

Author: viniarck

CHANGELOG.rst

@@ -28,6 +28,8 @@ Security
 Added
 =====
  - [v0x04] Fixed bug when unpacking MultiPart messages (#529). Thanks @jondef95
+ - [v0x04] Added support for for OpenFlow 1.3 OFP_ERROR codes with the get_class method
+ - [v0x01 | v0x04] Added GenericFailedCode error PR #533
 
 [2018.2b1] - "ernesto" beta1 - 2018-9-6
 ***************************************

pyof/v0x01/asynchronous/error_msg.py

@@ -11,7 +11,7 @@
 
 __all__ = ('ErrorMsg', 'ErrorType', 'BadActionCode', 'BadRequestCode',
            'FlowModFailedCode', 'HelloFailedCode', 'PortModFailedCode',
-           'QueueOpFailedCode')
+           'QueueOpFailedCode', 'GenericFailedCode')
 
 
 # Enums
@@ -49,7 +49,17 @@ def get_class(self):
                    'OFPET_FLOW_MOD_FAILED': FlowModFailedCode,
                    'OFPET_PORT_MOD_FAILED': PortModFailedCode,
                    'OFPET_QUEUE_OP_FAILED': QueueOpFailedCode}
-        return classes[self.name]
+        return classes.get(self.name, GenericFailedCode)
+
+
+class GenericFailedCode(IntEnum):
+    """Error_msg 'code' values for OFPET_BAD_ACTION.
+
+    'data' contains at least the first 64 bytes of the failed request.
+    """
+
+    #: Unknown error
+    GENERIC_ERROR = 0
 
 
 class HelloFailedCode(IntEnum):

pyof/v0x04/asynchronous/error_msg.py

@@ -15,11 +15,22 @@
            'FlowModFailedCode', 'GroupModFailedCode', 'HelloFailedCode',
            'MeterModFailedCode', 'PortModFailedCode', 'QueueOpFailedCode',
            'RoleRequestFailedCode', 'SwitchConfigFailedCode',
-           'TableFeaturesFailedCode', 'TableModFailedCode')
+           'TableFeaturesFailedCode', 'TableModFailedCode',
+           'GenericFailedCode')
 
 # Enums
 
 
+class GenericFailedCode(IntEnum):
+    """Error_msg 'code' values for OFPET_BAD_ACTION.
+
+    'data' contains at least the first 64 bytes of the failed request.
+    """
+
+    #: Unknown error
+    GENERIC_ERROR = 0
+
+
 class BadActionCode(IntEnum):
     """Error_msg 'code' values for OFPET_BAD_ACTION.
 
@@ -197,6 +208,29 @@ class ErrorType(IntEnum):
     #: Experimenter error messages.
     OFPET_EXPERIMENTER = 0xffff
 
+    def get_class(self):
+        """Return a Code class based on current ErrorType value.
+
+        Returns:
+            enum.IntEnum: class referenced by current error type.
+
+        """
+        classes = {'OFPET_HELLO_FAILED': HelloFailedCode,
+                   'OFPET_BAD_REQUEST': BadRequestCode,
+                   'OFPET_BAD_ACTION': BadActionCode,
+                   'OFPET_BAD_INSTRUCTION': BadInstructionCode,
+                   'OFPET_BAD_MATCH': BadMatchCode,
+                   'OFPET_FLOW_MOD_FAILED': FlowModFailedCode,
+                   'OFPET_GROUP_MOD_FAILED': GroupModFailedCode,
+                   'OFPET_PORT_MOD_FAILED': PortModFailedCode,
+                   'OFPET_QUEUE_OP_FAILED': QueueOpFailedCode,
+                   'OFPET_SWITCH_CONFIG_FAILED': SwitchConfigFailedCode,
+                   'OFPET_ROLE_REQUEST_FAILED': RoleRequestFailedCode,
+                   'OFPET_METER_MOD_FAILED': MeterModFailedCode,
+                   'OFPET_TABLE_MOD_FAILED': TableModFailedCode,
+                   'OFPET_TABLE_FEATURES_FAILED': TableFeaturesFailedCode}
+        return classes.get(self.name, GenericFailedCode)
+
 
 class FlowModFailedCode(IntEnum):
     """Error_msg 'code' values for OFPET_FLOW_MOD_FAILED.