Conversation
Signed-off-by: rafi <refaei.shikho@hotmail.com>
Signed-off-by: rafi <refaei.shikho@hotmail.com>
…nd assets Signed-off-by: rafi <refaei.shikho@hotmail.com>
…hing for subgroups and assets Signed-off-by: rafi <refaei.shikho@hotmail.com>
There was a problem hiding this comment.
Pull request overview
Adds a reusable UI component to render nested subgroups and assets, and updates organization/project pages to use it with lazy-loading of subgroup contents.
Changes:
- Introduces
SubgroupsAndAssetsList(recursive list UI with expand/collapse) and wires it into org/project pages. - Extends
ProjectDTOwithsubGroupsAndAssetto hold nested resources. - Updates
AssetOverviewListItemto support linking with an explicitprojectSlug.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| src/types/api/api.ts | Adds subGroupsAndAsset to ProjectDTO and imports a UI-defined type. |
| src/components/SubgroupsAndAssetsList.tsx | New recursive subgroup/asset list component with expand/collapse and lazy fetch hook-in. |
| src/components/AssetOverviewListItem.tsx | Allows passing a projectSlug override for correct asset links in nested views. |
| src/app/(loading-group)/[organizationSlug]/projects/[projectSlug]/page.tsx | Replaces inline list rendering with SubgroupsAndAssetsList and adds SWR mutation-based lazy loading. |
| src/app/(loading-group)/[organizationSlug]/page.tsx | Updates org home list rendering to use SubgroupsAndAssetsList and adds lazy loading for subgroup contents. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…nagement and update type definitions for subgroups and assets Signed-off-by: rafi <refaei.shikho@hotmail.com>
Signed-off-by: rafi <refaei.shikho@hotmail.com>
…Page Signed-off-by: rafi <refaei.shikho@hotmail.com>
…toriesPage Signed-off-by: rafi <refaei.shikho@hotmail.com>
…ge to indicate minimum character requirement Signed-off-by: rafi <refaei.shikho@hotmail.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated 9 comments.
Comments suppressed due to low confidence (1)
src/app/(loading-group)/[organizationSlug]/projects/[projectSlug]/page.tsx:86
- The page no longer passes SWR’s loading state into the list.
SubgroupsAndAssetsListonly shows loading when lazily expanding a subgroup, so the initial/resourcesfetch can render as an empty area until data arrives. Consider plumbing SWR’sisLoading/isValidatingintoSubgroupsAndAssetsList(or wrapping it withListRenderer) so initial load shows a skeleton/placeholder.
const {
data: subgroupsWithAssets,
error,
mutate,
} = useSWR<Paged<SubGroupsAndAsset>>(() => {
if (!isOrganization(organization.organization)) return null;
const base = `/organizations/${decodeURIComponent(organization.organization.slug)}/projects/${decodeURIComponent(project.slug)}/resources?parentId=${project?.id}`;
const query = queryWithState.toString();
return query ? `${base}&${query}` : base;
}, fetcher);
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…sPage to improve query handling and state management Signed-off-by: rafi <refaei.shikho@hotmail.com>
…tsList and RepositoriesPage Signed-off-by: rafi <refaei.shikho@hotmail.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated 6 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: rafi <refaei.shikho@hotmail.com>
…ets-list-component
No description provided.