fix: added a rule to the artifact form field#776
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a broken UI flow in the artifact form by adding a required-field validation rule to the artifactName input, leveraging react-hook-form’s Controller rules so submission is blocked and an inline error is shown when the field is empty.
Changes:
- Added a
requiredvalidation rule to theartifactNameFormFieldto prevent empty submissions. - Ensures the existing
<FormMessage />displays the required-field error message for this input.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
timbastin
approved these changes
Jun 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
l3montree-dev/devguard#1979
Added rules={{ required: "Artifact name is required" }} to the artifactName field so that react-hook-form blocks form submission and displays an inline validation error when the artifact name is left empty. This solves the broken ui issue.