Fix dependency risks loading spinner position#824
Merged
seb-kw merged 1 commit intoJul 14, 2026
Conversation
Signed-off-by: Nicholas Santi <nicksan222@gmail.com>
Contributor
Author
|
Loading-state screenshot:
|
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the dependency-risks page loading UX so loading feedback is presented in the results area (not inside the filter/search row) and prevents stale/empty UI states from showing while data is loading.
Changes:
- Removes the inline loading spinner from the filter/search row.
- Adds a centered loading spinner in the results section with a minimum height to stabilize layout.
- Gates the empty state behind the non-loading branch so it won’t appear while loading.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
juliankepka
approved these changes
Jul 14, 2026
juliankepka
left a comment
juliankepka
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for your PR!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
npx tsc --noEmit --pretty falseFixes l3montree-dev/devguard#2344