using min access level for project listing

Author: timbastin

internal/core/integrations/external_entity_provider_service.go

@@ -206,13 +206,19 @@ func (s externalEntityProviderService) createProjectsMap(created, updated []mode
 }
 
 func (s externalEntityProviderService) syncProjectsAndAssets(ctx core.Context, domainRBAC core.AccessControl, user string, originalProjects []models.Project, roles []core.Role, projects []models.Project) error {
+	wg := utils.ErrGroup[any](10)
 	for i, project := range projects {
-		if err := s.syncSingleProject(ctx, domainRBAC, user, &originalProjects[i], roles[i], &project); err != nil {
-			slog.Error("could not sync project", "projectSlug", project.Slug, "projectID", project.ID, "err", err)
-			continue
-		}
+		wg.Go(func() (any, error) {
+			if err := s.syncSingleProject(ctx, domainRBAC, user, &originalProjects[i], roles[i], &project); err != nil {
+				slog.Error("could not sync project", "projectSlug", project.Slug, "projectID", project.ID, "err", err)
+				// swallow the error right here
+			}
+			return nil, nil
+		})
+
 	}
-	return nil
+	_, err := wg.WaitAndCollect()
+	return err
 }
 
 func (s externalEntityProviderService) syncSingleProject(ctx core.Context, domainRBAC core.AccessControl, user string, originalProject *models.Project, userRole core.Role, project *models.Project) error {

internal/core/integrations/gitlabint/gitlab_integration.go

@@ -426,7 +426,8 @@ func (g *GitlabIntegration) ListProjects(ctx context.Context, userID string, pro
 	}
 	// get the projects in the group
 	projects, _, err := gitlabClient.ListProjectsInGroup(ctx, groupIDInt, &gitlab.ListGroupProjectsOptions{
-		WithShared: gitlab.Ptr(false),
+		WithShared:     gitlab.Ptr(false),
+		MinAccessLevel: gitlab.Ptr(gitlab.DeveloperPermissions), // only list projects where the user has at least developer permissions
 	})
 	if err != nil {
 		slog.Error("failed to list projects in group", "err", err)
@@ -441,6 +442,10 @@ func (g *GitlabIntegration) ListProjects(ctx context.Context, userID string, pro
 		if project.Permissions != nil && project.Permissions.ProjectAccess != nil {
 			result = append(result, projectToAsset(project, providerID))
 			accessLevels = append(accessLevels, gitlabAccessLevelToRole(project.Permissions.ProjectAccess.AccessLevel))
+		} else {
+			// if the project has no permissions set, it is a public project - but we asked for min access level of developer, so we can assume that the user has at least developer permissions
+			result = append(result, projectToAsset(project, providerID))
+			accessLevels = append(accessLevels, core.RoleMember) // default to member if no higher access level is found
 		}
 	}