made the endpoints more RESTful

Author: Hubtrick-Git

controllers/admin_controller.go

@@ -97,7 +97,7 @@ func (controller *AdminController) AddAdminToOrg(ctx shared.Context) error {
 		return echo.NewHTTPError(400, "missing or invalid user id")
 	}
 
-	user := ctx.Param("user")
+	user := ctx.Param("userID")
 
 	if !utils.IsEmail(user) {
 		return echo.NewHTTPError(400, "user is not a valid mail address")
@@ -116,15 +116,15 @@ func (controller *AdminController) AddAdminToOrg(ctx shared.Context) error {
 		case dtos.CouldNotFindDefinitiveUserWithMail:
 			return echo.NewHTTPError(400, "could not find a definitive user associated with this email")
 		default:
-			return echo.NewHTTPError(500, "could not determine user based on email")
+			return echo.NewHTTPError(500, "could not determine user based on email").WithInternal(err)
 		}
 	}
 
 	err = controller.adminService.AddAdminToOrg(context.Background(), parsedOrgID, userID)
 	if err != nil {
-		return echo.NewHTTPError(500, "could not add admin to organization")
+		return echo.NewHTTPError(500, "could not add admin to organization").WithInternal(err)
 	}
-	return ctx.JSON(200, nil)
+	return ctx.JSON(201, nil)
 }
 
 func (controller *AdminController) RevokeAdmin(ctx shared.Context) error {
@@ -134,7 +134,7 @@ func (controller *AdminController) RevokeAdmin(ctx shared.Context) error {
 		return echo.NewHTTPError(400, "missing or invalid user id")
 	}
 
-	user := ctx.Param("user")
+	user := ctx.Param("userID")
 
 	if !utils.IsEmail(user) {
 		return echo.NewHTTPError(400, "user is not a valid mail address")
@@ -160,7 +160,7 @@ func (controller *AdminController) RevokeAdmin(ctx shared.Context) error {
 	if err != nil {
 		return echo.NewHTTPError(500, "could not revoke admin role from user")
 	}
-	return ctx.JSON(200, nil)
+	return ctx.JSON(204, nil)
 }
 
 // checkCooldown reads the config DB for the last trigger time and returns an

router/admin_router.go

@@ -35,9 +35,9 @@ func NewAdminRouter(apiV1Router APIV1Router, adminController *controllers.AdminC
 		return ctx.JSON(200, map[string]string{"status": "ok"})
 	})
 
-	adminRouter.GET("/external-org/", adminController.GetAdminsForExternalOrgs)
-	adminRouter.POST("/external-org/:orgID/admin/:user", adminController.AddAdminToOrg)
-	adminRouter.DELETE("/external-org/:orgID/admin/:user", adminController.RevokeAdmin)
+	adminRouter.GET("/external-orgs", adminController.GetAdminsForExternalOrgs)
+	adminRouter.PUT("/external-orgs/:orgID/admins/:userID", adminController.AddAdminToOrg)
+	adminRouter.DELETE("/external-orgs/:orgID/admins/:userID", adminController.RevokeAdmin)
 
 	// Daemon trigger endpoints – each daemon has its own SSE trigger route
 	daemonGroup := adminRouter.Group("/daemons")