changes according to code review

Author: timbastin

accesscontrol/casbin_rbac_test.go

@@ -16,14 +16,14 @@ import (
 // in-memory by casbin's model layer; this adapter only satisfies the interface.
 type noopAdapter struct{}
 
-func (noopAdapter) LoadPolicy(_ casbinModel.Model) error                        { return nil }
-func (noopAdapter) SavePolicy(_ casbinModel.Model) error                        { return nil }
-func (noopAdapter) AddPolicy(_, _ string, _ []string) error                     { return nil }
-func (noopAdapter) RemovePolicy(_, _ string, _ []string) error                  { return nil }
-func (noopAdapter) RemoveFilteredPolicy(_, _ string, _ int, _ ...string) error  { return nil }
-func (noopAdapter) LoadPolicyCtx(_ context.Context, _ casbinModel.Model) error  { return nil }
-func (noopAdapter) SavePolicyCtx(_ context.Context, _ casbinModel.Model) error  { return nil }
-func (noopAdapter) AddPolicyCtx(_ context.Context, _, _ string, _ []string) error { return nil }
+func (noopAdapter) LoadPolicy(_ casbinModel.Model) error                             { return nil }
+func (noopAdapter) SavePolicy(_ casbinModel.Model) error                             { return nil }
+func (noopAdapter) AddPolicy(_, _ string, _ []string) error                          { return nil }
+func (noopAdapter) RemovePolicy(_, _ string, _ []string) error                       { return nil }
+func (noopAdapter) RemoveFilteredPolicy(_, _ string, _ int, _ ...string) error       { return nil }
+func (noopAdapter) LoadPolicyCtx(_ context.Context, _ casbinModel.Model) error       { return nil }
+func (noopAdapter) SavePolicyCtx(_ context.Context, _ casbinModel.Model) error       { return nil }
+func (noopAdapter) AddPolicyCtx(_ context.Context, _, _ string, _ []string) error    { return nil }
 func (noopAdapter) RemovePolicyCtx(_ context.Context, _, _ string, _ []string) error { return nil }
 func (noopAdapter) RemoveFilteredPolicyCtx(_ context.Context, _, _ string, _ int, _ ...string) error {
 	return nil

accesscontrol/members.go

@@ -14,4 +14,3 @@
 // along with this program.  If not, see <https://www.gnu.org/licenses/>.
 
 package accesscontrol
-

cmd/devguard-scanner/commands/sign.go

@@ -82,7 +82,7 @@ func signCmd(cmd *cobra.Command, args []string) error {
 		&cosignoptions.RootOptions{},
 		ko,
 		fileOrImageName,
-		false, // b64
+		false,  // b64
 		"", "", // outputSignature, outputCertificate
 		false, // tlogUpload
 	)

controllers/asset_controller.go

@@ -19,14 +19,14 @@ import (
 )
 
 type AssetController struct {
-	assetRepository              shared.AssetRepository
-	assetVersionRepository       shared.AssetVersionRepository
+	assetRepository               shared.AssetRepository
+	assetVersionRepository        shared.AssetVersionRepository
 	artifactRiskHistoryRepository shared.ArtifactRiskHistoryRepository
-	assetService                 shared.AssetService
-	dependencyVulnService        shared.DependencyVulnService
-	statisticsService            shared.StatisticsService
-	thirdPartyIntegration        shared.IntegrationAggregate
-	daemonRunner                 shared.DaemonRunner
+	assetService                  shared.AssetService
+	dependencyVulnService         shared.DependencyVulnService
+	statisticsService             shared.StatisticsService
+	thirdPartyIntegration         shared.IntegrationAggregate
+	daemonRunner                  shared.DaemonRunner
 
 	utils.FireAndForgetSynchronizer
 }
@@ -476,7 +476,7 @@ func (a *AssetController) GetBadges(ctx shared.Context) error {
 	}
 	var artifactName *string
 	artifact, err := shared.MaybeGetArtifact(ctx)
-	if err == nil && artifact != nil {
+	if err == nil {
 		artifactName = &artifact.ArtifactName
 	}
 

controllers/dependencyfirewall/oci.go

@@ -25,7 +25,6 @@ import (
 	"net/http"
 	"net/url"
 	"os"
-	
 	"regexp"
 	"strings"
 	"time"

controllers/helpers.go

@@ -28,7 +28,7 @@ func ctxToBOMMetadata(ctx shared.Context) normalize.BOMMetadata {
 	assetVersion := shared.GetAssetVersion(ctx)
 	artifactName := ""
 	artifact, err := shared.MaybeGetArtifact(ctx)
-	if err != nil || artifact == nil {
+	if err != nil {
 		org := shared.GetOrg(ctx)
 		project := shared.GetProject(ctx)
 

database/models/component_model.go

@@ -93,7 +93,7 @@ func (c ComponentDependencyNode) GetID() string {
 func (c ComponentDependency) ToNodes() []ComponentDependencyNode {
 	// a component dependency represents an edge in the dependency tree
 	// thus we can represent it as two nodes
-	return []ComponentDependencyNode{ComponentDependencyNode{ID: utils.SafeDereference(c.ComponentID)}, ComponentDependencyNode{ID: c.DependencyID}}
+	return []ComponentDependencyNode{{ID: utils.SafeDereference(c.ComponentID)}, {ID: c.DependencyID}}
 }
 
 func resolveLicense(component ComponentDependency, componentLicenseOverwrites map[string]string) cyclonedx.Licenses {

database/repositories/gitlab_integration_repository.go

@@ -112,10 +112,10 @@ func (r *gitlabOauth2TokenRepository) CreateIfNotExists(ctx context.Context, tx
 	return r.GetDB(ctx, tx).Clauses(clause.OnConflict{
 		DoNothing: true,
 		Columns: []clause.Column{
-			clause.Column{
+			{
 				Name: "provider_id",
 			},
-			clause.Column{
+			{
 				Name: "user_id",
 			},
 		},

database/repositories/malicious_package_repository.go

@@ -24,9 +24,9 @@ import (
 )
 
 type MaliciousPackageRepository struct {
-	db         *gorm.DB
-	pkgRepo    *GormRepository[string, models.MaliciousPackage]
-	compRepo   *GormRepository[string, models.MaliciousAffectedComponent]
+	db       *gorm.DB
+	pkgRepo  *GormRepository[string, models.MaliciousPackage]
+	compRepo *GormRepository[string, models.MaliciousAffectedComponent]
 }
 
 func NewMaliciousPackageRepository(db *gorm.DB) *MaliciousPackageRepository {
@@ -67,4 +67,3 @@ func (r *MaliciousPackageRepository) GetMaliciousPackageByID(ctx context.Context
 	err := r.GetDB(ctx, tx).Where("id = ?", id).First(&maliciousPackage).Error
 	return maliciousPackage, err
 }
-

fixedversion/vulnerability_path_analysis_fixed_version_resolver_test.go

@@ -68,7 +68,6 @@ func TestEnsureDirectDependencyFixedVersionPURL(t *testing.T) {
 	})
 }
 
-
 func TestBuildFullPackageName(t *testing.T) {
 	tests := []struct {
 		name     string