Skip to content

Commit daaeda7

Browse files
committed
Refactor vulnerability handling to return early if no vulnerabilities are present
Signed-off-by: Rafi <refaei.shikho@hotmail.com>
1 parent e480cd8 commit daaeda7

2 files changed

Lines changed: 9 additions & 1 deletion

File tree

internal/core/assetversion/asset_version_service.go

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -204,6 +204,11 @@ func (s *service) handleFirstPartyVulnResult(userID string, scannerID string, as
204204
})
205205

206206
go func() {
207+
208+
if len(newVulns) == 0 {
209+
return
210+
}
211+
207212
pro, err := s.projectRepository.GetProjectByAssetID(asset.ID)
208213
if err != nil {
209214
slog.Error("could not get project by asset ID", "err", err)
@@ -285,6 +290,9 @@ func (s *service) HandleScanResult(asset models.Asset, assetVersion *models.Asse
285290
assetVersion.Metadata[scannerID] = models.ScannerInformation{LastScan: utils.Ptr(time.Now())}
286291

287292
go func() {
293+
if len(opened) == 0 {
294+
return
295+
}
288296
pro, err := s.projectRepository.GetProjectByAssetID(asset.ID)
289297
if err != nil {
290298
slog.Error("could not get project by asset ID", "err", err)

internal/database/repositories/component_repository.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -325,7 +325,7 @@ func (c *componentRepository) HandleStateDiff(tx core.DB, assetVersionName strin
325325
added := comparison.OnlyInB
326326
needToBeChanged := comparison.InBoth
327327

328-
if len(removed) > 0 || len(added) > 0 || len(needToBeChanged) > 0 {
328+
if len(removed) > 0 || len(added) > 0 {
329329
stateChanged = true
330330
}
331331

0 commit comments

Comments
 (0)