fix: handle multiple info-source parents in SBOM graph without panicking#2012
Merged
Conversation
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: rafi <refaei.shikho@hotmail.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates SBOM graph path-finding to tolerate malformed graphs where a single info-source node has multiple parent artifacts, avoiding a hard panic while preserving correct scoped path results.
Changes:
- Replaced the panic on “info source has multiple parents” with a warning + monitoring alert and updated scoping logic to accept any parent matching the current scope.
- Added a regression test covering the multi-parent info-source scenario to ensure scoped path results remain correct.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| normalize/sbom_graph.go | Avoids panic on multi-parent info sources; logs/alerts and keeps scoped path computation working by checking all parents for the current scope. |
| normalize/sbom_graph_test.go | Adds coverage ensuring scoped path results remain correct when an info source has two parent artifacts. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
timbastin
reviewed
May 20, 2026
Signed-off-by: Tim Bastin <38261809+timbastin@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Signed-off-by: Tim Bastin <38261809+timbastin@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.