Skip to content

fix: return 401 instead of 404 for disallowed public requests #2034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
timbastin merged 1 commit into from
May 21, 2026
+1 −1
Merged

fix: return 401 instead of 404 for disallowed public requests #2034

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion middlewares/access_control_middlewares.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ func DisallowPublicRequests(next echo.HandlerFunc) echo.HandlerFunc {
return func(ctx shared.Context) error {
if shared.IsPublicRequest(ctx) {
slog.Warn("access denied for public request in DisallowPublicRequests middleware")
return echo.NewHTTPError(404, "could not find resource")
return echo.NewHTTPError(401, "this endpoint is not accessible for public requests")
}
return next(ctx)
}
Expand Down
Loading