364 add dependency graph to GitHub and gitlab tickets using mermaidjs#427
Merged
timbastin merged 16 commits intoApr 7, 2025
Merged
Conversation
added 5 commits
April 1, 2025 13:32
… improvements still
timbastin
requested changes
Apr 1, 2025
| } | ||
|
|
||
| // this function returns a string containing a mermaids js flow chart to the given pURL | ||
| func (g *gitlabIntegration) renderPathToComponent(assetID uuid.UUID, assetVersionName string, scannerID string, pURL string) (string, error) { |
Member
There was a problem hiding this comment.
I think you can reduce the duplication of this logic by creating its own function, which gets the component repository as parameter. And please write a test for it 🙂
Collaborator
Author
|
Code is ready .The only thing left to do is write tests |
timbastin
requested changes
Apr 2, 2025
removed the debug bin file Signed-off-by: Patrick <patrick.rissmann@l3montree.com>
Collaborator
Author
|
Disclaimer I know that the FormatNode function should not be public but i can't use it in the integrations_text package otherwise. |
timbastin
requested changes
Apr 3, 2025
Member
Maybe it is just simpler to change the mermaidjs diagram from |
…orientation of the flowchart
Merging this branch changes the coverage (1 decrease, 1 increase)
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files
|
timbastin
approved these changes
Apr 7, 2025
timbastin
deleted the
364-add-dependency-graph-to-github-and-gitlab-tickets-using-mermaidjs
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues now show a mermaid flow chart with the individual components in their description . Could need some artistic and formating improvements.