844 license risks#878
Merged
Merged
Conversation
…n and we check the existing license risks before creating new ones
Closed
Collaborator
Author
|
Do we also need to include the scanner ids in the Calculate hash function since, the super key is technically assetID, assetVersionName, pURL and scanner ID since the same component in the same assetVersion can be found by multiple scanner leading to duplicate vulnIDs? |
Collaborator
Author
|
did not yet merge with main, makes the code review probably easier and there is yet again a problem with go embed in the asset version controller |
Member
|
I think this should work now - would be great to have a test for it... |
timbastin
reviewed
Jul 23, 2025
timbastin
approved these changes
Jul 25, 2025
Merging this branch changes the coverage (6 decrease, 4 increase)
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added license risk table to the database
Dependency Vuln Scans now automatically check each dependency if they have a valid license
Added endpoints to interact with License Risks just like dependency-/firstParty-Vulns
On-top a user can manually set a final license
Wrote some simple test to test helper functions