chore: enhance CI pipeline with e2e tests and pre-commit hooks #1

Copilot · 2026-04-21T09:23:36Z

npx drizzle-kit check will fail in CI unless DATABASE_URL is provided. drizzle.config.ts throws when process.env.DATABASE_URL is missing, and this workflow doesn’t set it. Set DATABASE_URL from a GitHub secret (or spin up a Postgres service and point DATABASE_URL at it) for this step.

Suggested change

- name: Database Schema validation

- name: Database Schema validation

env:

DATABASE_URL: ${{ secrets.DATABASE_URL }}

coderabbitai · 2026-04-21T09:22:52Z

⚠️ Potential issue | 🟠 Major

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash # Inspect drizzle config to see which env vars it reads at load time. fd -HI 'drizzle.config.*' fd -HI 'drizzle.config.*' --exec cat {} # See if any .env.example documents the required runtime env fd -HI -t f '.env*'

Repository: lab68dev/lab68cvbuilder

Length of output: 868

🏁 Script executed:

# Find and inspect playwright.config.ts fd -HI 'playwright.config.*' --exec cat {} # Find and inspect next.config fd -HI 'next.config.*' --exec cat {} # Check if there are any test environment files or setup fd -HI -t f -e 'env.test' -o -e 'vitest.config' -o -e 'jest.config' # Check for .env files ls -la | grep -E '\.env'

Repository: lab68dev/lab68cvbuilder

Length of output: 2818

🏁 Script executed:

# Examine the CI file more carefully for env configuration and line 45 whitespace sed -n '38,50p' .github/workflows/ci.yml | cat -A

Repository: lab68dev/lab68cvbuilder

Length of output: 417

🏁 Script executed:

# Search for DATABASE_URL usage in the codebase to understand test setup rg "DATABASE_URL" --max-count 20 -B 2 -A 2

Repository: lab68dev/lab68cvbuilder

Length of output: 759

🏁 Script executed:

# Check for actual runtime env dependencies in the app rg "process\.env\." --max-count 30 -o | sort | uniq -c | sort -rn # Look for next-auth configuration rg "nextauth|NextAuthOptions|NextAuth" -t ts -t tsx --max-count 10 # Check for groq and cloudinary usage rg "groq|cloudinary|GROQ|CLOUDINARY" --max-count 10 # Look for any CI test setup or environment configuration fd -t f '.github/workflows/ci.yml' --exec cat {}

Repository: lab68dev/lab68cvbuilder

Length of output: 2912

🏁 Script executed:

# Check if there are any test setup files or mocking fd -HI -t f 'setup|mock|fixture' | head -20 # Look for .env.example or similar documentation rg "^(DATABASE_URL|AUTH_SECRET|NEXTAUTH|GROQ|CLOUDINARY)" -t txt

Repository: lab68dev/lab68cvbuilder

Length of output: 49

🏁 Script executed:

# Check auth configuration requirements rg "NEXTAUTH|AUTH_SECRET|NEXT_PUBLIC_URL" --max-count 15 # Look for the actual E2E tests to understand what routes are tested fd -HI -t f -path '*/e2e/*' | head -20

Repository: lab68dev/lab68cvbuilder

Length of output: 235

🏁 Script executed:

# Check if app will even start without env vars (look for app layout or middleware) rg "throw new Error|process\.env\." src/app/layout.tsx src/middleware.ts 2>/dev/null | head -20 # Check what routes exist and if they require auth/env fd -HI -t f -path '*/app/\[locale\]/*' | grep -E 'route\.(ts|tsx)' | head -10

Repository: lab68dev/lab68cvbuilder

Length of output: 235

🏁 Script executed:

# Search for auth configuration in the codebase rg "NEXTAUTH|AUTH_SECRET|NEXT_PUBLIC" -g "*.ts" -g "*.tsx" --max-count 15 # Look for E2E test files fd -type f "e2e" | head -20 # Find all test files rg "describe|test\(" -l | grep -E "(e2e|test)" | head -15

Repository: lab68dev/lab68cvbuilder

Length of output: 1001

🏁 Script executed:

# Check the CI workflow file completely to see if any env is configured cat .github/workflows/ci.yml

Repository: lab68dev/lab68cvbuilder

Length of output: 980

E2E and schema-check steps will fail in CI without environment variables.

drizzle-kit check (Line 41) will throw an error. The drizzle.config.ts explicitly requires DATABASE_URL at load time and has no fallback—it throws "DATABASE_URL environment variable is not set" if missing. Add DATABASE_URL via GitHub Secrets and expose it in the workflow step's env: block.

E2E Tests (Line 47) will fail. The playwright.config.ts runs npm run dev, and the app depends on GROQ_API_KEY (used in src/actions/tailor.ts, cover-letter.ts, ai.ts) and CLOUDINARY_URL (used in src/app/api/upload/avatar/route.ts). Routes calling these APIs will return 500 errors, causing Playwright tests to fail or hang. Inject these secrets in the E2E step's env: block or mock them in test mode.

Also recommended:

Use npx playwright install --with-deps chromium so system libraries are installed on ubuntu-latest.

Consider running E2E against next build && next start instead of next dev for closer-to-production behavior.

Remove trailing whitespace from Line 45.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed. In @.github/workflows/ci.yml around lines 40 - 47, The CI workflow will fail because `drizzle-kit check` (Database Schema validation step) requires DATABASE_URL at load time and the Playwright E2E step needs GROQ_API_KEY and CLOUDINARY_URL; update the "Database Schema validation" step to export DATABASE_URL from GitHub Secrets in an env: block, and update the "E2E Tests (Playwright)" step to export GROQ_API_KEY and CLOUDINARY_URL (or set test-mode mocks) in its env: block, switch the Playwright install command to `npx playwright install --with-deps chromium` and consider running `next build && next start` instead of `next dev` for E2E to match production; also remove the trailing whitespace on the workflow line flagged.

Copilot · 2026-04-21T09:23:38Z

This Husky hook is missing a shebang (and the Husky shim if your setup expects it). Without #!/usr/bin/env sh at the top, Git can fail to execute it on Linux/macOS with an “Exec format error”. Add the standard Husky header and ensure the file is executable.

coderabbitai · 2026-04-21T09:22:52Z

⚠️ Potential issue | 🟠 Major

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash # Confirm builder route shape and that no top-level /builder/page.tsx exists fd -HI -t f 'page.tsx' src/app | rg -n 'builder' # Look for any data-testid attributes already wired into the builder UI rg -nP 'data-testid=' src/components/builder src/app 2>/dev/null | head -50 # Confirm the fullName input attributes rg -nP -C2 '"fullName"|placeholder="John Doe"' src/components/builder/forms/personal-info-form.tsx

Repository: lab68dev/lab68cvbuilder

Length of output: 755

🏁 Script executed:

#!/bin/bash # 1. Get full context of the fullName input element cat -n src/components/builder/forms/personal-info-form.tsx | sed -n '835,855p' # 2. Search for all data-testid attributes in builder components echo "=== data-testid attributes in builder ===" rg 'data-testid=' src/components/builder src/app/\[locale\]/builder 2>/dev/null | head -30 # 3. Find the jobTitle input field echo "=== Job Title input field ===" rg -B3 -A3 'jobTitle|job.title' src/components/builder/forms/personal-info-form.tsx | head -50 # 4. Check for preview container references echo "=== Preview container selectors ===" rg -n 'preview-container|resume-preview|data-testid.*preview' src/components/builder src/app 2>/dev/null # 5. Check if builder route requires authentication echo "=== Builder route auth check ===" rg -B5 -A5 'middleware|auth|redirect' src/app/\[locale\]/builder/\[id\]/page.tsx | head -30

Repository: lab68dev/lab68cvbuilder

Length of output: 2072

🏁 Script executed:

#!/bin/bash # Find job title / position input in the form echo "=== Job Title/Position Input ===" rg -n -B2 -A4 'position|Job Title' src/components/builder/forms/personal-info-form.tsx | grep -A6 'input' # Search for job title input attribute definitions rg -n 'name=.*title|placeholder=.*[Tt]itle' src/components/builder/forms/personal-info-form.tsx # Search for ATS-related elements in the codebase echo "=== ATS Button/Panel Search ===" rg -rn 'ATS|Analyze|ats-feedback|ats-button|Score' src/components/builder src/app 2>/dev/null | grep -i 'button\|text\|locator\|aria' | head -20 # Check for ATS component or feature echo "=== ATS Component Files ===" fd -H -t f '.*ats.*|.*recommendation.*' src 2>/dev/null # Check auth setup in test files echo "=== Auth Setup in Tests ===" rg -n 'auth|session|globalSetup|storageState' e2e 2>/dev/null

Repository: lab68dev/lab68cvbuilder

Length of output: 587

🏁 Script executed:

#!/bin/bash # Get file sizes to understand scope echo "=== File sizes ===" wc -l src/components/builder/forms/personal-info-form.tsx src/components/builder/resume-score.tsx src/components/builder/builder-client.tsx 2>/dev/null # Check all input elements in personal-info-form echo "=== All input elements in personal-info-form ===" rg -n '<input' src/components/builder/forms/personal-info-form.tsx # Check resume-score.tsx for button structure echo "=== resume-score.tsx button elements ===" rg -n 'button|onClick|className.*ats' src/components/builder/resume-score.tsx | head -30 # Look for preview container in builder layout echo "=== Preview container in builder ===" rg -n 'preview|canvas|data-testid' src/components/builder/builder-client.tsx src/components/builder/builder-layout.tsx 2>/dev/null | head -20 # Check experience form for position/job title echo "=== Experience form position input ===" rg -B2 -A4 'position|positionInput' src/components/builder/forms/experience-form.tsx | head -40 # Verify e2e has no globalSetup echo "=== E2E test setup ===" ls -la e2e/ | grep -E 'setup|auth|config' cat e2e/playwright.config.ts 2>/dev/null | head -40

Repository: lab68dev/lab68cvbuilder

Length of output: 1982

🏁 Script executed:

#!/bin/bash # Read full resume-score.tsx echo "=== Full resume-score.tsx ===" cat -n src/components/builder/resume-score.tsx # Read builder-preview.tsx to check for preview container classes echo "=== builder-preview.tsx ===" cat -n src/components/builder/builder-preview.tsx # Check experience-form for position input structure echo "=== Position input in experience-form ===" rg -n -B3 -A8 'value={exp.position}' src/components/builder/forms/experience-form.tsx

Repository: lab68dev/lab68cvbuilder

Length of output: 12658

🏁 Script executed:

#!/bin/bash # Check builder-client.tsx full content echo "=== builder-client.tsx ===" cat -n src/components/builder/builder-client.tsx # Check for builder layout echo "=== builder-layout.tsx ===" cat -n src/components/builder/builder-layout.tsx 2>/dev/null || echo "Not found" # Search for ResumeScorePanel usage echo "=== ResumeScorePanel usage ===" rg -rn 'ResumeScorePanel' src 2>/dev/null

Repository: lab68dev/lab68cvbuilder

Length of output: 8088

This spec will not meaningfully exercise the flow it describes — multiple correctness issues.

Several problems combine to make this E2E test either flaky, silently passing without doing anything, or outright failing:

Wrong builder route. The builder page lives at src/app/[locale]/builder/[id]/page.tsx, so /en/builder (Line 13) is not a valid route — it will 404 or redirect. You need to create a resume first (dashboard → "Create Resume") or navigate to a seeded id, e.g. /en/builder/<seeded-id>.

No authentication. Comments acknowledge next-auth is used, but the test neither logs in nor installs a mock session / storage state. The builder route has if (!session?.user) { redirect("/login"); }, so you'll be redirected before any form is visible. Use Playwright's auth storage state or a globalSetup that seeds a session cookie.

Invalid Playwright selector syntax. page.locator('text="ATS", text="Analyze", button:has-text("Score")') (Line 52) and 'text="Recommendations", text="Suggestions", .ats-feedback' (Line 59) are not valid. Playwright does not parse comma-separated mixtures of the text= engine and CSS inside a single selector string. Use locator.or() or role-based selectors instead:

const scoreSection = page.getByRole("button", { name: /score/i });

Selectors don't match the real DOM. The full-name input has placeholder "John Doe" but no name or aria-label="Full Name" attribute (see src/components/builder/forms/personal-info-form.tsx Line 844). No top-level "job title" input exists — position is nested in the experience section. The preview pane has no .preview-container, .resume-preview, or [data-testid="resume-preview"] classes — it's just a styled div in builder-preview.tsx. Add data-testid attributes to components and target those instead.

Silent no-op pattern. Guarding fills with if ((await locator.count()) > 0) means the test can pass without ever filling anything or navigating. E2E tests should fail if preconditions aren't met, not silently skip.

ATS feature is not clickable. ResumeScorePanel (in resume-score.tsx) is a static display component that shows score rings and checklist items — not a modal or panel that appears after clicking a button. Users navigate to the "Score" section in the form sidebar to view it. There is no "click to get recommendations" button.

Given the scope of rework, I'd recommend landing this behind a skipped test.describe.skip(...) until auth setup, real selectors (via data-testid), correct route navigation, and accurate ATS flow understanding are in place.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed. In `@e2e/builder.spec.ts` around lines 1 - 64, The E2E spec (e2e/builder.spec.ts) is flaky/incorrect because it navigates to a non-existent route, doesn’t establish auth, uses invalid/incorrect selectors and silently no-ops; fix it by: 1) navigate to a valid builder URL (create a resume via the dashboard flow or use a seeded id instead of "/en/builder"); 2) establish an authenticated session before visiting the builder using Playwright auth storage state or globalSetup so session?.user check passes; 3) replace invalid selector strings (the atsButton locator and recommendation locators) with proper Playwright APIs like page.getByRole/getByText or locator.or and target concrete test ids; 4) update selectors to match real DOM elements (use data-testid attributes added in src/components/builder/forms/personal-info-form.tsx and builder-preview.tsx) and remove the count()-guard pattern so the test fails fast if required elements are missing; 5) adjust ATS interaction to reflect the real UX (open the Score section or check ResumeScorePanel in resume-score.tsx) rather than clicking a non-existent button.

Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		npx lint-staged
Copy link Copilot AI Apr 21, 2026 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others. Learn more. This Husky hook is missing a shebang (and the Husky shim if your setup expects it). Without `#!/usr/bin/env sh` at the top, Git can fail to execute it on Linux/macOS with an “Exec format error”. Add the standard Husky header and ensure the file is executable. Copilot uses AI. Check for mistakes.

-Original file line number
+Diff line change
@@ -0,0 +1,11 @@
+    import { test, expect } from "@playwright/test";
+    test.describe("CV Builder Navigation", () => {
+      test("User can load the login page", async ({ page }) => {
+        await page.goto("/en/login");
+        // Check if the page loaded successfully by looking for standard initial elements
+        await expect(page.locator("form, button, h1, body").first()).toBeVisible({
+          timeout: 10000,
+        });
+      });
+    });

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: enhance CI pipeline with e2e tests and pre-commit hooks #1

Uh oh!

Diff view

Diff view

There are no files selected for viewing

Copilot AI Apr 21, 2026

Uh oh!

coderabbitai Bot Apr 21, 2026

Uh oh!

Copilot AI Apr 21, 2026

Uh oh!

coderabbitai Bot Apr 21, 2026

Uh oh!

Uh oh!

Uh oh!

chore: enhance CI pipeline with e2e tests and pre-commit hooks #1

Uh oh!

chore: enhance CI pipeline with e2e tests and pre-commit hooks #1

Uh oh!

Uh oh!

Diff view

Diff view

There are no files selected for viewing

Copilot AI Apr 21, 2026

Choose a reason for hiding this comment

Uh oh!

coderabbitai Bot Apr 21, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 21, 2026

Choose a reason for hiding this comment

Uh oh!

coderabbitai Bot Apr 21, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!