Skip to content

Resolving unamed url raised Resolver404 and prevent preview #270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
weber-s wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Resolving unamed url raised Resolver404 and prevent preview #270

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/wagtail_2fa/middleware.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

import django_otp
from django.conf import settings
from django.urls.exceptions import Resolver404
from django.contrib.auth.views import redirect_to_login
from django.urls import resolve, reverse
from django.utils.functional import SimpleLazyObject
Expand Down Expand Up @@ -74,7 +75,11 @@ def _require_verified_user(self, request):
return False

# Don't require verification for specified URL names
request_url_name = resolve(request.path_info).url_name
try:
request_url_name = resolve(request.path_info).url_name
except Resolver404:
return False

if request_url_name in self._allowed_url_names:
return False

Expand Down